Mercurial > p > roundup > code
comparison doc/upgrading.txt @ 5192:302e3a1a7190
Three sets of changes:
1) Make sure that a user doesn't create a query with the same name
as an existing query that the user owns.
2) When submitting a new named query, display the name of the query
on the index page.
3) Allow optional arguments to indexargs_url by setting their value
to None. This will show the argument only if there is a valid
value.
To match these, changed the template for all search templates so if an
error is thrown due to #1 the user stays on the search page so they
can fix the issue.
Note that I did not add automated tests for these because I couldn't
find existing tests for these code paths that I could adapt. I don't
understand how the existing Action tests work and there is no doc for
them.
| author | rouilj@uland |
|---|---|
| date | Wed, 08 Mar 2017 22:04:15 -0500 |
| parents | 36630a062fb5 |
| children | 3124be3cc197 |
comparison
equal
deleted
inserted
replaced
| 5191:fe52cab8f5b5 | 5192:302e3a1a7190 |
|---|---|
| 393 | 393 |
| 394 It is suggested that you change your checks to use the ``**ctx`` | 394 It is suggested that you change your checks to use the ``**ctx`` |
| 395 parameter. This is expected to be the preferred form in the future. | 395 parameter. This is expected to be the preferred form in the future. |
| 396 You do not need to use the ``ctx`` parameter in the function if you do | 396 You do not need to use the ``ctx`` parameter in the function if you do |
| 397 not need it. | 397 not need it. |
| 398 | |
| 399 Improve query editing | |
| 400 --------------------- | |
| 401 | |
| 402 The query editing interface will now report an error if the user | |
| 403 creates a new query that they are already using. By default the query | |
| 404 editing page (issue.search.html) displays the index page when the | |
| 405 search is triggered. Since the user expects to see the results of the | |
| 406 query, this is usually the right thing. But now that the code properly | |
| 407 checks for duplicate search names, the user should stay on the search | |
| 408 page if there is an error. To add this to your existing | |
| 409 index.search.html page, add the following line after the hidden field | |
| 410 @old-queryname: | |
| 411 | |
| 412 <input type="hidden" name="@template" value="index|search"/> | |
| 413 | |
| 414 With this addition, the index template is displayed if there is no | |
| 415 error, and the user stays on the search template if there is an error. | |
| 398 | 416 |
| 399 Migrating from 1.5.0 to 1.5.1 | 417 Migrating from 1.5.0 to 1.5.1 |
| 400 ============================= | 418 ============================= |
| 401 | 419 |
| 402 User data visibility | 420 User data visibility |