Mercurial > p > roundup > code
comparison roundup/cgi/client.py @ 8261:28c5030757d3
fix: cae1bbf2536b - expression errors not setting result properly
Rather than setting 'result' in renderContext, I was wrirting the
output directly, but was stil falling through to where result would be
used.
This caused email to be sent to the admin and when test_mailgw was
called the mail-test.log was somehow created and caused the test there
to fail.
Fixed renderContext to use result variable and output contents of
mail-test.log to make debugging easier.
This should fix CI failure.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sun, 05 Jan 2025 00:59:12 -0500 |
| parents | cae1bbf2536b |
| children | 35beff316883 |
comparison
equal
deleted
inserted
replaced
| 8260:617d85ce4ac3 | 8261:28c5030757d3 |
|---|---|
| 2231 except IndexerQueryError as e: | 2231 except IndexerQueryError as e: |
| 2232 result = self.renderError(e.args[0]) | 2232 result = self.renderError(e.args[0]) |
| 2233 except ExpressionError as e: | 2233 except ExpressionError as e: |
| 2234 self.add_error_message(str(e)) | 2234 self.add_error_message(str(e)) |
| 2235 self.template = "search" | 2235 self.template = "search" |
| 2236 self.write_html(self.renderContext()) | 2236 result = self.renderContext() |
| 2237 | 2237 |
| 2238 if 'Content-Type' not in self.additional_headers: | 2238 if 'Content-Type' not in self.additional_headers: |
| 2239 self.additional_headers['Content-Type'] = pt.content_type | 2239 self.additional_headers['Content-Type'] = pt.content_type |
| 2240 if self.env.get('CGI_SHOW_TIMING', ''): | 2240 if self.env.get('CGI_SHOW_TIMING', ''): |
| 2241 if self.env['CGI_SHOW_TIMING'].upper() == 'COMMENT': | 2241 if self.env['CGI_SHOW_TIMING'].upper() == 'COMMENT': |