comparison roundup/msgfmt.py @ 5395:23b8e6067f7c

Python 3 preparation: update calls to dict methods. Tool-assisted patch. Changes of iterkeys / itervalues / iteritems to keys / values / items are fully automated, but may make things less efficient in Python 2. Automated tools want to add list() around many calls to keys / values / items, but I thought most such list() additions were unnecessary because it seemed the result of keys / values / items was just iterated over while the set of dict keys remained unchanged, rather than used in a way requiring an actual list, or used while the set of keys in the dict could change. It's quite possible I missed some cases where list() was really needed, or left in some unnecessary list() calls. In cases where list() was only needed because the resulting list was then sorted in-place, I changed the code to use calls to sorted().
author Joseph Myers <jsm@polyomino.org.uk>
date Tue, 24 Jul 2018 23:04:42 +0000
parents 64c4e43fbb84
children f2fade4552c5
comparison
equal deleted inserted replaced
5394:c26d88ec071e 5395:23b8e6067f7c
56 56
57 57
58 def generate(): 58 def generate():
59 "Return the generated output." 59 "Return the generated output."
60 global MESSAGES 60 global MESSAGES
61 keys = MESSAGES.keys()
62 # the keys are sorted in the .mo file 61 # the keys are sorted in the .mo file
63 keys.sort() 62 keys = sorted(MESSAGES.keys())
64 offsets = [] 63 offsets = []
65 ids = strs = '' 64 ids = strs = ''
66 for id in keys: 65 for id in keys:
67 # For each string, we need size and file offset. Each string is NUL 66 # For each string, we need size and file offset. Each string is NUL
68 # terminated; the NUL does not count into the size. 67 # terminated; the NUL does not count into the size.

Roundup Issue Tracker: http://roundup-tracker.org/