Mercurial > p > roundup > code
comparison test/test_cgi.py @ 8472:224ccb8b49ca
refactor: change some classes to use __slots__
Speed up access to and reduce size of some low level classes. A few
classes in security.py, rest.py are heavily used. But for all, it
prevents adding random properties to lower level classes that people
shouldn't be mucking with. While doing this I found some test cases
accessing an invalid property name and this change caused the cases to
crash.
admin.py:
Use new method Role.props_dict() and Permission.props_dict() where
original code just referenced __dict__ when printing Role/Permission.
mlink_expr.py:
Add slots to multiple classes.
Classes Binary and Unary set real properties/attributes. Classes that
inherit from them (Equals, Empty, Not, Or, And) define empty slots
tuple to eliminate need for __dict__.
Class Expression also gets a slot.
rate_limit.py:
RateLimit and Gcra classes get slots.
A couple of pep8 fixes: sort imports, remove trailing spaces on a
line, remove unused noqa comment.
rest.py:
Add slots to class SimulateFieldStorageFromJson and FsValue
classes. The memory savings from this could be useful as well as
speedier access to the attributes.
security.py:
Add slots to Permission class. To prevent conflict between slot
limit_perm_to_props_only and the class variable of the same name,
rename the class variable to limit_perm_to_props_only_default.
Also define method props_dict() to allow other code to get a dict to
iterate over when checking permissions.
Add slots to class Role along with props_dict() method.
Add slots to class Security. Also have to add explicit __dict__ slot
to support test override of the hasPermission() method. Add
props_dict() method, currently unused, but added for symmetry.
support.py:
TruthDict and PrioList gets slots.
test/test_cgi.py:
Fix incorrect setting of permission property. Was setting
permissions. So testing may not have been doing what we thought it
was. Multiple places found with this typo.
Remove setting of permissions in some places where it should
have no effect on the test and looks like it was just copypasta.
test/test_xmlrpc.py
Remove setting of permissions in some places where it should
have no effect on the test and looks like it was just copypasta.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Mon, 03 Nov 2025 00:13:04 -0500 |
| parents | b07165add61b |
| children | 166cb2632315 |
comparison
equal
deleted
inserted
replaced
| 8471:8e72dc7b7f2f | 8472:224ccb8b49ca |
|---|---|
| 1971 cl.nodeid = '1' | 1971 cl.nodeid = '1' |
| 1972 self.assertRaises(exceptions.Unauthorised, | 1972 self.assertRaises(exceptions.Unauthorised, |
| 1973 actions.EditItemAction(cl).handle) | 1973 actions.EditItemAction(cl).handle) |
| 1974 | 1974 |
| 1975 def testCheckAndPropertyPermission(self): | 1975 def testCheckAndPropertyPermission(self): |
| 1976 self.db.security.permissions = {} | 1976 self.db.security.permission = {} |
| 1977 def own_record(db, userid, itemid): | 1977 def own_record(db, userid, itemid): |
| 1978 return userid == itemid | 1978 return userid == itemid |
| 1979 p = self.db.security.addPermission(name='Edit', klass='user', | 1979 p = self.db.security.addPermission(name='Edit', klass='user', |
| 1980 check=own_record, properties=("password", )) | 1980 check=own_record, properties=("password", )) |
| 1981 self.db.security.addPermissionToRole('User', p) | 1981 self.db.security.addPermissionToRole('User', p) |
| 2002 actions.EditItemAction(cl).handle) | 2002 actions.EditItemAction(cl).handle) |
| 2003 | 2003 |
| 2004 def testCreatePermission(self): | 2004 def testCreatePermission(self): |
| 2005 # this checks if we properly differentiate between create and | 2005 # this checks if we properly differentiate between create and |
| 2006 # edit permissions | 2006 # edit permissions |
| 2007 self.db.security.permissions = {} | 2007 self.db.security.permission = {} |
| 2008 self.db.security.addRole(name='UserAdd') | 2008 self.db.security.addRole(name='UserAdd') |
| 2009 # Don't allow roles | 2009 # Don't allow roles |
| 2010 p = self.db.security.addPermission(name='Create', klass='user', | 2010 p = self.db.security.addPermission(name='Create', klass='user', |
| 2011 properties=("username", "password", "address", | 2011 properties=("username", "password", "address", |
| 2012 "alternate_address", "realname", "phone", "organisation", | 2012 "alternate_address", "realname", "phone", "organisation", |
| 2059 self.assertRaises(exceptions.Unauthorised, | 2059 self.assertRaises(exceptions.Unauthorised, |
| 2060 actions.EditItemAction(cl).handle) | 2060 actions.EditItemAction(cl).handle) |
| 2061 | 2061 |
| 2062 def testSearchPermission(self): | 2062 def testSearchPermission(self): |
| 2063 # this checks if we properly check for search permissions | 2063 # this checks if we properly check for search permissions |
| 2064 self.db.security.permissions = {} | |
| 2065 self.db.security.addRole(name='User') | 2064 self.db.security.addRole(name='User') |
| 2066 self.db.security.addRole(name='Project') | 2065 self.db.security.addRole(name='Project') |
| 2067 self.db.security.addPermissionToRole('User', 'Web Access') | 2066 self.db.security.addPermissionToRole('User', 'Web Access') |
| 2068 self.db.security.addPermissionToRole('Project', 'Web Access') | 2067 self.db.security.addPermissionToRole('Project', 'Web Access') |
| 2069 # Allow viewing department | 2068 # Allow viewing department |