comparison CHANGES.txt @ 8268:05d8806b25ad

fix: issue2551387 - TypeError: not indexable. Fix crash due to uninitialized list element on a (Mini)FieldStorage when unexpected input is posted via wsgi. This doesn't happen when running roundup-server. It might happen under other front ends. Moved the code that sets '.list = [] if .list == None' to the main flow. Added an exception hander that logs the value of self.form if self.form.list raises an AttributeError. This exception should never happen if I understand the code correctly (but I probably don't). Fixed a number of test cases that were broken because I was calling Client and passing '[]' rather than a cgi.formStorage object. Added test cases: create a FileStorage (self.form) with .list = None. check AttributeError exception and verify logging. Problem reported and debugged by Christof Meerwald.
author John Rouillard <rouilj@ieee.org>
date Sun, 12 Jan 2025 12:34:52 -0500
parents 35beff316883
children 341841a9edc5
comparison
equal deleted inserted replaced
8267:7f0c7966d204 8268:05d8806b25ad
65 has been changed. Checking user authorization to use the REST 65 has been changed. Checking user authorization to use the REST
66 interface is done before validating the Origin header. As a 66 interface is done before validating the Origin header. As a
67 result, incorrectly formatted CORS preflight requests 67 result, incorrectly formatted CORS preflight requests
68 (e.g. missing Origin header) can now return HTTP status 403 as 68 (e.g. missing Origin header) can now return HTTP status 403 as
69 well as status 400. (John Rouillard) 69 well as status 400. (John Rouillard)
70 - issue2551387 - TypeError: not indexable. Fix crash due to
71 uninitialized list element on a (Mini)FieldStorage when unexpected
72 input is posted via wsgi. (Reported and debugged by Christof
73 Meerwald; fix John Rouillard)
70 74
71 Features: 75 Features:
72 76
73 - issue2551287 - Enhance roundup_gettext.py to extract strings from 77 - issue2551287 - Enhance roundup_gettext.py to extract strings from
74 detectors/extensions. If the polib module is available, 78 detectors/extensions. If the polib module is available,

Roundup Issue Tracker: http://roundup-tracker.org/