http://hg.code.sf.net:8000/p/roundup/code/atom-log/tip/roundup/roundupdb.py Mercurial Repository: p/roundup/code: roundup/roundupdb.py history 2025-03-01T13:08:09+01:00 Factor common code to hyperdb/roundupdb http://hg.code.sf.net:8000/p/roundup/code/#changeset-24549122f9b112ed873b7ef1536d37ba4f746d7b Ralf Schlatterbeck rsc@runtux.com 2025-03-01T13:08:09+01:00 2025-03-01T13:08:09+01:00
changeset 24549122f9b1
branch
bookmark
tag
user Ralf Schlatterbeck <rsc@runtux.com>
description Factor common code to hyperdb/roundupdb

There was some common copied code in backends/back_anydbm.py and
backends/rdbms_common.py. This is now moved to hyperdb.py and
roundupdb.py, respectively (the FileClass lives in hyperdb.py while the
IssueClass is in roundupdb.py)
files
fix(i18n): fix incorrect lookup of some translations http://hg.code.sf.net:8000/p/roundup/code/#changeset-216662fbaaee8fcda219c91784d2d4cbcee3240d John Rouillard rouilj@ieee.org 2024-03-01T14:04:05-05:00 2024-03-01T14:04:05-05:00
changeset 216662fbaaee
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description fix(i18n): fix incorrect lookup of some translations

The code had:

_("some term %s here" % term)

this extracts the template, but looks up the string with %s replaced.
So the translation is broken. Changed to:

_("some term %s here") % term

which looks up the template and substitutes in the translation of the
template.

Found by ruff INT ruleset.
files
flake8: rename loop variable in 'for sendto in sendto:' http://hg.code.sf.net:8000/p/roundup/code/#changeset-2b0089104f08289cc55584ae2acb6321c8dec2b3 John Rouillard rouilj@ieee.org 2023-07-23T23:40:12-04:00 2023-07-23T23:40:12-04:00
changeset 2b0089104f08
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description flake8: rename loop variable in 'for sendto in sendto:'

Flake8 reported 'B020 Found for loop that reassigns the iterable it is
iterating with each iterable value.'

Renamed loop variable to to_addr. There is a similar construct with a
loop over bcc_sendto with a 'bcc' loop variable. So I assume the loop
varaible can be chnaged w/o issue.

Codecov shows all the affected lines are being tested and the tests I
ran with testmon that should cover that code all passed.

We shall see if a full CI run passes.
files
Add config argument to more password.Password invocations. http://hg.code.sf.net:8000/p/roundup/code/#changeset-506c86823abbdeb0aae419b9197e0c200c020a9e John Rouillard rouilj@ieee.org 2023-03-04T00:17:26-05:00 2023-03-04T00:17:26-05:00
changeset 506c86823abb
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description Add config argument to more password.Password invocations.

The work done to allow password_pbkdf2_default_rounds to be overridden
for testing requires that calls to password.Password include a config
argument.

This was needed because using the real value more than quadrupled
testing runtime.

However there are still a few places where config was not being set
when Password was called. I think this fixes all of the ones that are
called from a function that have access to a db.config object.

The remaining ones all call Password(encrypted=x). This results in
Password.unpack() being called. If x is not a propertly formatted
password string ("{scheme}...", it calls encodePassword. It then
should end up raising the ConfigNotSet exception. This is
probably what we want as it means the shape of "x" is not correct.

I don't understand why Password.unpack() attempts to encrypt the value
of encrypted if it doesn't match the right form. According to codecov,
this encryption branch is being used, so somewhere x is of the wrong
form. Hmmm....
files
remove some unreachable code. If condition is always the same. http://hg.code.sf.net:8000/p/roundup/code/#changeset-ff879aa00987cdbbf6bb11911a31a6a7e4ce85b2 John Rouillard rouilj@ieee.org 2022-09-12T23:33:21-04:00 2022-09-12T23:33:21-04:00
changeset ff879aa00987
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description remove some unreachable code. If condition is always the same.

There is a test:

if not value: continue

then there is code below that at the same level that tests for:

if value:

and

if value is None:

Neither of these tests can be anything but the static values of True
and False respectively. Simplify code by removing the tests.
files
flake8 fixes - use None as sentinel http://hg.code.sf.net:8000/p/roundup/code/#changeset-de3118b4d22476e488282789828f17905f18ad61 John Rouillard rouilj@ieee.org 2022-09-12T23:25:10-04:00 2022-09-12T23:25:10-04:00
changeset de3118b4d224
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description flake8 fixes - use None as sentinel

Changed two methods:

nosymessage
send_message

that used def X( ... cc=[] ...) mutable args. Changed them to use None
as sentinel and added code to set the values appropriately when
sentinel seen.

Plus other flake8 fixes.
files
Add i18n object to roundupdb.Database http://hg.code.sf.net:8000/p/roundup/code/#changeset-408fd477761fa40fd7dfa13c4a25be572cd46dd9 Ralf Schlatterbeck rsc@runtux.com 2022-05-03T14:51:59+02:00 2022-05-03T14:51:59+02:00
changeset 408fd477761f
branch
bookmark
tag
user Ralf Schlatterbeck <rsc@runtux.com>
description Add i18n object to roundupdb.Database

This makes the i18n object accessible everywhere (including in detectors
where localized error messages were impossible). See issue2551184
files
Change authid order to fix test. http://hg.code.sf.net:8000/p/roundup/code/#changeset-cf1b51a3a368e75332ec0423812d5fe124558b9b John Rouillard rouilj@ieee.org 2021-05-27T16:40:10-04:00 2021-05-27T16:40:10-04:00
changeset cf1b51a3a368
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description Change authid order to fix test.
files
send_message allows setting message sender via authid. http://hg.code.sf.net:8000/p/roundup/code/#changeset-443f80297ac197aaacadedeb5fe2e89bca8dd910 John Rouillard rouilj@ieee.org 2021-05-27T15:54:55-04:00 2021-05-27T15:54:55-04:00
changeset 443f80297ac1
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description send_message allows setting message sender via authid.

Adapted from: http://hg.python.org/tracker/roundup/rev/ad317e38
files
Allow to define reverse Multilinks http://hg.code.sf.net:8000/p/roundup/code/#changeset-8497bf3f23a13059a2b21666f0c8d4ee28a55601 Ralf Schlatterbeck rsc@runtux.com 2020-04-29T16:30:27+02:00 2020-04-29T16:30:27+02:00
changeset 8497bf3f23a1
branch
bookmark
tag
user Ralf Schlatterbeck <rsc@runtux.com>
description Allow to define reverse Multilinks

Now it's possible to specify a rev_multilink parameter when creating
Link or Multilink properties. The parameter takes a property name to be
inserted into the linked-to class. It allows to navigate from the other
side of the link as if it where a forward Multilink using the existing
data structures.
files
flake8 cleanup formatting plus http://hg.code.sf.net:8000/p/roundup/code/#changeset-2b53c310089fbaf45705293aa5e7f8521c3eae50 John Rouillard rouilj@ieee.org 2019-12-28T14:51:50-05:00 2019-12-28T14:51:50-05:00
changeset 2b53c310089f
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description flake8 cleanup formatting plus

type comparisons replaced with isinstance
removal of unused imports
bare except -> except Exception:
files
- issue2550920 - Optionally detect duplicate username at registration. http://hg.code.sf.net:8000/p/roundup/code/#changeset-71c68961d9f4171f782b87a462347313a123967d John Rouillard rouilj@ieee.org 2019-11-09T16:33:42-05:00 2019-11-09T16:33:42-05:00
changeset 71c68961d9f4
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description - issue2550920 - Optionally detect duplicate username at registration.

Added config option to allow detection of duplicate username when the
user tries to register. Previously user was rejected when dupliate
name found at confirmation step.

Optional as it can make username guessing easier.

Testing is in place for this.

Also attempted to make the unfriendly error message:

'node with key "username" exists'

into a translatable friendly error:

"Username 'username' already exists."

This is missing any test. It is also fragile as I capture the
ValueError exception and see that the exception matches:

'node with key "username" exists'

If it does reassert the friendly message. Otherwise just re-raise
existing exception. If the "node with key..." message is translated
the friendly override will not trigger.
files
Additional headers for nosymessage http://hg.code.sf.net:8000/p/roundup/code/#changeset-11a9c5b2efd4f20f51cdbb1c0baabccff680a58d Ralf Schlatterbeck rsc@runtux.com 2019-11-05T13:22:20+01:00 2019-11-05T13:22:20+01:00
changeset 11a9c5b2efd4
branch
bookmark
tag
user Ralf Schlatterbeck <rsc@runtux.com>
description Additional headers for nosymessage

Nice if a message needs to be marked as urgent or similar, e.g., Outlook
uses an "Importance" header, when set to "high" it highlights the
message.
files
issue2551043: Add X-Roundup-issue-id email header. http://hg.code.sf.net:8000/p/roundup/code/#changeset-2c0f89edabe19c562c5f1effefe38d967c869c35 John Rouillard rouilj@ieee.org 2019-06-01T13:19:14-04:00 2019-06-01T13:19:14-04:00
changeset 2c0f89edabe1
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description issue2551043: Add X-Roundup-issue-id email header.

Add a new header to make it easier to filter notification emails
without having to parse the subject line. Modified tests to account
for new header.
files
issue2551018 add new nosy_filter parameter to nosymessage. Function http://hg.code.sf.net:8000/p/roundup/code/#changeset-f3d68c1bb96ea8cb96d3bb30b5c773f2886bbb7d John Rouillard rouilj@ieee.org 2019-03-25T19:45:08-04:00 2019-03-25T19:45:08-04:00
changeset f3d68c1bb96e
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description issue2551018 add new nosy_filter parameter to nosymessage. Function
passed as nosy_filter can rewrite the nosy message body before it's
sent. Tom Ekberg tekberg did the work.
files
use gpg module instead of pyme module for PGP encryption http://hg.code.sf.net:8000/p/roundup/code/#changeset-b7fa56ced601c5293f7a5d735eaf193973a2f682 Christof Meerwald cmeerw@cmeerw.org 2018-08-12T16:17:14+01:00 2018-08-12T16:17:14+01:00
changeset b7fa56ced601
branch
bookmark
tag
user Christof Meerwald <cmeerw@cmeerw.org>
description use gpg module instead of pyme module for PGP encryption
files
updated mailgw to no longer use mimetools based on jerrykan's patch http://hg.code.sf.net:8000/p/roundup/code/#changeset-725266c03eab7b5df86fa532c40123826ee7fc2b Christof Meerwald cmeerw@cmeerw.org 2018-08-12T16:15:10+01:00 2018-08-12T16:15:10+01:00
changeset 725266c03eab
branch
bookmark
tag
user Christof Meerwald <cmeerw@cmeerw.org>
description updated mailgw to no longer use mimetools based on jerrykan's patch
files
reworked random number use http://hg.code.sf.net:8000/p/roundup/code/#changeset-52cb53eedf777c4c915a89f44a5059285039b6e0 Christof Meerwald cmeerw@cmeerw.org 2018-08-04T22:40:16+01:00 2018-08-04T22:40:16+01:00
changeset 52cb53eedf77
branch
bookmark
tag
user Christof Meerwald <cmeerw@cmeerw.org>
description reworked random number use
prefer secrets module from Python 3.6+, random.SystemRandom and finally plain random
files
mailer string encoding fixes http://hg.code.sf.net:8000/p/roundup/code/#changeset-3afda04c96a17fc2e6411ac61563da9a4f7af730 Christof Meerwald cmeerw@cmeerw.org 2018-07-29T01:31:48+01:00 2018-07-29T01:31:48+01:00
changeset 3afda04c96a1
branch
bookmark
tag
user Christof Meerwald <cmeerw@cmeerw.org>
description mailer string encoding fixes
files
Python 3 preparation: update email module names. http://hg.code.sf.net:8000/p/roundup/code/#changeset-a0ed8d5d744f1b22fcbfc55182e03af278b34e5c Joseph Myers jsm@polyomino.org.uk 2018-07-25T09:29:34+00:00 2018-07-25T09:29:34+00:00
changeset a0ed8d5d744f
branch
bookmark
tag
user Joseph Myers <jsm@polyomino.org.uk>
description Python 3 preparation: update email module names.

Various email.* modules were renamed in Python 2.5, and backwards
compatibility for the old names was removed in Python 3.
files
Python 3 preparation: StringIO. http://hg.code.sf.net:8000/p/roundup/code/#changeset-55f09ca366c484e1c06dd34a4efead3f1634d7d7 Joseph Myers jsm@polyomino.org.uk 2018-07-25T09:08:29+00:00 2018-07-25T09:08:29+00:00
changeset 55f09ca366c4
branch
bookmark
tag
user Joseph Myers <jsm@polyomino.org.uk>
description Python 3 preparation: StringIO.

This generally arranges for StringIO and cStringIO references to use
io.StringIO for Python 3 but io.BytesIO for Python 2, consistent with
the string representations generally used in Roundup. A special
FasterStringIO in the TAL code, which referenced internals of the old
Python 2 StringIO module, is cut down so it doesn't actually do
anything beyond the StringIO class it inherits from (it would also be
reasonable to remove FasterStringIO completely). One place in
roundup_server.py clearly needing binary I/O is made to use io.BytesIO
unconditionally.
files
Python 3 preparation: unicode. http://hg.code.sf.net:8000/p/roundup/code/#changeset-56c9bcdea47f22412e4f0768775d1abea52d19c2 Joseph Myers jsm@polyomino.org.uk 2018-07-25T09:05:58+00:00 2018-07-25T09:05:58+00:00
changeset 56c9bcdea47f
branch
bookmark
tag
user Joseph Myers <jsm@polyomino.org.uk>
description Python 3 preparation: unicode.

This patch introduces roundup/anypy/strings.py, which has a comment
explaining the string representations generally used and common
functions to handle the required conversions. Places in the code that
explicitly reference the "unicode" type / built-in function are
generally changed to use the new functions (or, in a few places where
those new functions don't seem to fit well, other approaches such as
references to type(u'') or use of the codecs module). This patch does
not generally attempt to address text conversions in any places not
currently referencing the "unicode" type (although
scripts/import_sf.py is made to use binary I/O in places as fixing the
"unicode" reference didn't seem coherent otherwise).
files
Python 3 preparation: update calls to dict methods. http://hg.code.sf.net:8000/p/roundup/code/#changeset-23b8e6067f7cdf5ff451f0a99cac4fb288e56859 Joseph Myers jsm@polyomino.org.uk 2018-07-24T23:04:42+00:00 2018-07-24T23:04:42+00:00
changeset 23b8e6067f7c
branch
bookmark
tag
user Joseph Myers <jsm@polyomino.org.uk>
description Python 3 preparation: update calls to dict methods.

Tool-assisted patch. Changes of iterkeys / itervalues / iteritems to
keys / values / items are fully automated, but may make things less
efficient in Python 2. Automated tools want to add list() around many
calls to keys / values / items, but I thought most such list()
additions were unnecessary because it seemed the result of keys /
values / items was just iterated over while the set of dict keys
remained unchanged, rather than used in a way requiring an actual
list, or used while the set of keys in the dict could change. It's
quite possible I missed some cases where list() was really needed, or
left in some unnecessary list() calls.

In cases where list() was only needed because the resulting list was
then sorted in-place, I changed the code to use calls to sorted().
files
Python 3 preparation: change "x.has_key(y)" to "y in x". http://hg.code.sf.net:8000/p/roundup/code/#changeset-0942fe89e82e3e84d95a3d0ca5d8d15502f57348 Joseph Myers jsm@polyomino.org.uk 2018-07-24T22:08:17+00:00 2018-07-24T22:08:17+00:00
changeset 0942fe89e82e
branch
bookmark
tag
user Joseph Myers <jsm@polyomino.org.uk>
description Python 3 preparation: change "x.has_key(y)" to "y in x".

(Also likewise "not in" where appropriate.) Tool-generated patch.
files
Python 3 preparation: "raise" syntax. http://hg.code.sf.net:8000/p/roundup/code/#changeset-35ea9b1efc1494f29fb07690e7087686de58e0f3 Joseph Myers jsm@polyomino.org.uk 2018-07-24T21:39:58+00:00 2018-07-24T21:39:58+00:00
changeset 35ea9b1efc14
branch
bookmark
tag
user Joseph Myers <jsm@polyomino.org.uk>
description Python 3 preparation: "raise" syntax.

Changing "raise Exception, value" to "raise Exception(value)".
Tool-assisted patch. Particular cases to check carefully are the one
place in frontends/ZRoundup/ZRoundup.py where a string exception
needed to be fixed, and the one in roundup/cgi/client.py involving
raising an exception with a traceback (requires three-argument form of
raise in Python 2, which as I understand it requires exec() to avoid a
Python 3 syntax error).
files
A real fix for the problem where: http://hg.code.sf.net:8000/p/roundup/code/#changeset-91954be46a66ab9f301cfbabf6cfb9a269d324dd John Rouillard rouilj@ieee.org 2018-07-08T11:34:42-04:00 2018-07-08T11:34:42-04:00
changeset 91954be46a66
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description A real fix for the problem where:

import random

would result in every call to random() returning the same value
in the web interface.

While cgi/client.py:Client::__init.py__ was calling random.seed(),
on most systems random was SystemRandom and not the default random.

As a result the random as you would get from:

import random

was never being seeded. I added a function to access and seed the
random bound instance of random.Random that is called during init.

This fixes all three places where I saw the broken randomness.
It should also fix:

http://psf.upfronthosting.co.za/roundup/meta/issue644

I also removed the prior code that would bail if systemRandom was not
available.
files
Force all uses of random to use SystemRandom and abort if http://hg.code.sf.net:8000/p/roundup/code/#changeset-66a17c80e03503a503efa70475e918c1265ced80 John Rouillard rouilj@ieee.org 2018-07-07T22:02:41-04:00 2018-07-07T22:02:41-04:00
changeset 66a17c80e035
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description Force all uses of random to use SystemRandom and abort if
pseudorandom random.Random would be used rather than
Random.SystemRandom.

random.Random is returning the same value time after time. Even when
being seeded after instantiation, calls to the random.random()
function return the same value like it's not advanceing the state of
the generator.

So "fix" is to force use of system random generator to generate:

one time keys for password reset (action.py)
random passwords when resetting passwords (password.py)
serial number for auto ssl cert generation (roundup_server.py)
Message-ID's in email: mailgw.py, client.py
anti-csrf nonces (templating.py)
files
Fix commits although a Reject exception is raised http://hg.code.sf.net:8000/p/roundup/code/#changeset-62de601bdf6fd224fead26c33b585af5a05e7d80 Ralf Schlatterbeck rsc@runtux.com 2018-04-20T18:46:28+02:00 2018-04-20T18:46:28+02:00
changeset 62de601bdf6f
branch
bookmark
tag
user Ralf Schlatterbeck <rsc@runtux.com>
description Fix commits although a Reject exception is raised

Fix the problem that changes are committed to the database (due to
commits to otk handling) even when a Reject exception occurs. The fix
implements separate database connections for otk/session handling and
normal database operation.
files
issue2550957: Duplicate emails (with patch). http://hg.code.sf.net:8000/p/roundup/code/#changeset-a4fe76fba54a695fd3c31322da662875f4889a09 John Rouillard rouilj@ieee.org 2017-11-07T20:58:48-05:00 2017-11-07T20:58:48-05:00
changeset a4fe76fba54a
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description issue2550957: Duplicate emails (with patch).

Bcc and cc users passed to nosymessage are not properly recorded.
This results in duplicate emails. Patch by Trent Gamblin (trentgg).
Applied by and test added by John Rouillard.
files
Apply patch attached to issue2550937 traceback/crash due to passing http://hg.code.sf.net:8000/p/roundup/code/#changeset-0121b2f1f041178d97669a5e171ed8a032f06a31 John Rouillard rouilj@ieee.org 2017-04-05T22:04:04-04:00 2017-04-05T22:04:04-04:00
changeset 0121b2f1f041
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description Apply patch attached to issue2550937 traceback/crash due to passing
empty sendto to smtp_send. Fix by Trent Gamblin.

http://issues.roundup-tracker.org/issue2550937
files
Fix issue2550751: Email Header Issue. http://hg.code.sf.net:8000/p/roundup/code/#changeset-a927f9549af0f703ddfe8ee10ef4cb02dd7b6a67 John Rouillard rouilj@ieee.org 2016-07-03T19:29:50-04:00 2016-07-03T19:29:50-04:00
changeset a927f9549af0
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description Fix issue2550751: Email Header Issue.

Noel Garces requested the ability to suppress email headers like
"x-roundup-issue-files". With Ralf's addition of the Link/Multilink
property attribute 'msg_header_property' we can do this
easily. Setting the 'msg_header_property' to the empty string '' (not
to None) will suppress the header for that property.

3 line code change, single test, doc updated and change note.
files
- issue1714899: Feature Request: Optional Change Note. Added a new http://hg.code.sf.net:8000/p/roundup/code/#changeset-8901cc4ef0e0bc18cc20ef7d00300878136c990e John Rouillard rouilj@ieee.org 2016-06-30T20:38:23-04:00 2016-06-30T20:38:23-04:00
changeset 8901cc4ef0e0
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description - issue1714899: Feature Request: Optional Change Note. Added a new
quiet=True/False option for all property types. When quiet=True
changes to the property will not be displayed in the::

confirmation banner (shown in green) when a change is made
property change section of change note (nosy emails)
web history display for an item.

Note that this may confuse users if used on a property that is
meant to be changed by a user. It is most useful on administrative
properties that are changed by an auditor as part of a user
generated change. Original patch by Daniel Diniz (ajaksu2)
discussed also at:
http://psf.upfronthosting.co.za/roundup/meta/issue249
Support for setting quiet when calling the class specifiers:
E.G. prop=String(quiet=True) rather than::
prop=String()
prop.quiet=True
support for anydb backend, added tests, doc updates, support for
ignoring quiet setting using showall=True in call to history()
function in templates by John Rouillard.

In addition to documenting quiet, I also documented required and
default_value additions to the hyperdb property classes. Only place I
could find is design.txt.

Note tests for history in web interface are not done. It was manually
checked but there are no automated tests. The template for setup is in
db_test_base.py::testQuietJournal but it has no asserts. I need
access to template.py::_HTMLItem::history() and I don't know how to do
that. test_templates.py isn't helping me any at all and I want to get
this patch in because it handles nicely an issue I have in the design
of my own tracker. The issue is:

The properties of an issue are displayed in framesets/subframes. The
user can roll up the frameset leaving only the title bar. When the
user saves the changes, the current state of the framesets
(collapsed/uncollapsed) is saved to a property in the user's
object. However there is no reason the user should see that this is
updated since it's an administrative detail.

Similarly, you could count the number of times an issue is reopened or
reassigned. Updates to properties that are an indirect result of a
user's change should not be displayed to the user as they can be
confusing and distracting.
files
issue2550803: Replying to NOSY mail goes to the tracker through http://hg.code.sf.net:8000/p/roundup/code/#changeset-99e28935979856b69d212a9da77491d4acaf04cb John Rouillard rouilj@ieee.org 2016-06-26T00:36:23-04:00 2016-06-26T00:36:23-04:00
changeset 99e289359798
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description issue2550803: Replying to NOSY mail goes to the tracker through
reply-to, not original message author.

Created new [tracker] replyto_address config.ini option to allow:
1) setting reply-to header to the tracker
2) setting reply-to header to the address of the author
of the change
3) setting it to a fixed address (like noreply@some.place)

Proposal by Peter Funk (pefu) in discussion with Tom Ekberg
(tekberg).

I chose to re-retrieve the email address for the author from the
database rather than adding a new variable. Also managed to make
a test case for each of the three settings.
files
issue2109308 add subject argument to nosymessage. Initial patch Frank Niessink. Test and application with slight mods by rouilj http://hg.code.sf.net:8000/p/roundup/code/#changeset-786f0581bc90fad922578e311bcf861d9535dc90 John Rouillard rouilj@ieee.org 2016-06-11T18:06:18-04:00 2016-06-11T18:06:18-04:00
changeset 786f0581bc90
branch
bookmark
tag
user John Rouillard <rouilj@ieee.org>
description issue2109308 add subject argument to nosymessage. Initial patch Frank Niessink. Test and application with slight mods by rouilj
files
New Link/Multilink attribute 'msg_header_property' http://hg.code.sf.net:8000/p/roundup/code/#changeset-2840a9e86ef28e7eb077e4a87e97cced4c37d57b Ralf Schlatterbeck rsc@runtux.com 2016-05-10T16:26:24+02:00 2016-05-10T16:26:24+02:00
changeset 2840a9e86ef2
branch
bookmark
tag
user Ralf Schlatterbeck <rsc@runtux.com>
description New Link/Multilink attribute 'msg_header_property'

.. can be used to configure additional headers in outgoing emails.
files
Remove FeedParser shim from anypy.email_ http://hg.code.sf.net:8000/p/roundup/code/#changeset-28a72f125a14aaf5f266af2ee8899a02c6c71ae7 John Kristensen john@jerrykan.com 2014-05-09T18:23:54+10:00 2014-05-09T18:23:54+10:00
changeset 28a72f125a14
branch
bookmark
tag
user John Kristensen <john@jerrykan.com>
description Remove FeedParser shim from anypy.email_

The FeedParser shim was being used to provide support for python v2.4,
but Roundup no longer has support for python v2.4 so we can get rid of
it.
files
Fixing duplicated email headers message-id, reply-to, in-reply-to. (part of issue2550869). http://hg.code.sf.net:8000/p/roundup/code/#changeset-010ce624b3202665652b3c3f5ac8c282532238a9 Bernhard Reiter bernhard@intevation.de 2015-03-10T21:39:52+01:00 2015-03-10T21:39:52+01:00
changeset 010ce624b320
branch
bookmark
tag
user Bernhard Reiter <bernhard@intevation.de>
description Fixing duplicated email headers message-id, reply-to, in-reply-to. (part of issue2550869).
files
Fixed OpenPGP support for modern versions of libgpgme. http://hg.code.sf.net:8000/p/roundup/code/#changeset-ef4f1cefac9c7f0265777750d050460a7638b66a Bernhard Reiter bernhard@intevation.de 2013-01-17T22:15:05+01:00 2013-01-17T22:15:05+01:00
changeset ef4f1cefac9c
branch
bookmark
tag
user Bernhard Reiter <bernhard@intevation.de>
description Fixed OpenPGP support for modern versions of libgpgme.
files
nested_scopes are here since Python 2.2 http://hg.code.sf.net:8000/p/roundup/code/#changeset-9cc6d463cfbe65fab31383ece94a2fe73cb84616 anatoly techtonik techtonik@gmail.com 2013-01-17T09:08:50+03:00 2013-01-17T09:08:50+03:00
changeset 9cc6d463cfbe
branch
bookmark
tag
user anatoly techtonik <techtonik@gmail.com>
description nested_scopes are here since Python 2.2
files
Add an interface to register clearCache callbacks in roundupdb. http://hg.code.sf.net:8000/p/roundup/code/#changeset-dfbc0cfa9811e364f92fe906259fdbb57767c97d Ralf Schlatterbeck rsc@runtux.com 2012-08-17T15:30:36+02:00 2012-08-17T15:30:36+02:00
changeset dfbc0cfa9811
branch
bookmark
tag
user Ralf Schlatterbeck <rsc@runtux.com>
description Add an interface to register clearCache callbacks in roundupdb.

Sometimes complicated computations may require an application cache.
This application can now register a callback to clear the application
cache, because roundup knows better when to clear it (usually when a
transaction ends, either with rollback or with commit). The interface
for this is currently considered experimental. The current interface
is registerClearCacheCallback(self, method, param) where method is
called with param as the only parameter.
files
Add config-option "nosy" to messages_to_author setting in [nosy] section... http://hg.code.sf.net:8000/p/roundup/code/#changeset-d9d7319afffac1a2356746110d6e9fadca84c564 Ralf Schlatterbeck schlatterbeck@users.sourceforge.net 2011-10-19T11:32:20-04:00 2011-10-19T11:32:20-04:00
changeset d9d7319afffa
branch
bookmark
tag
user Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
description Add config-option "nosy" to messages_to_author setting in [nosy] section...

...of config: This will send a message to the author only in the case where
the author is on the nosy-list (either added earlier or via the
add_author setting). Current config-options for this setting will send /
not send to author without considering the nosy list.

[[Posted on behalf of Dr. Schlatterbeck during the git conversion.]]

committer: Eric S. Raymond <esr@thyrsus.com>
files
Sending of PGP-Encrypted mail to all users or selected users (via roles)... http://hg.code.sf.net:8000/p/roundup/code/#changeset-46239c21a1ebdb739a6368c98325f0892db336c8 Ralf Schlatterbeck schlatterbeck@users.sourceforge.net 2011-10-07T18:04:00+00:00 2011-10-07T18:04:00+00:00
changeset 46239c21a1eb
branch
bookmark
tag
user Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
description Sending of PGP-Encrypted mail to all users or selected users (via roles)...

...is now working. (Ralf)
files
PGP support is again working (pyme API has changed significantly)... http://hg.code.sf.net:8000/p/roundup/code/#changeset-62239a524bebe3d4954bb43d095907ef4b31b7c5 Ralf Schlatterbeck schlatterbeck@users.sourceforge.net 2011-10-07T14:21:57+00:00 2011-10-07T14:21:57+00:00
changeset 62239a524beb
branch
bookmark
tag
user Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
description PGP support is again working (pyme API has changed significantly)...

...and we now have a regression test. We now take care that
bounce-messages for incoming encrypted mails or mails where the policy
dictates that outgoing traffic should be encrypted is actually
pgp-encrypted. Note that the new pgp encrypt option for outgoing mails
works only for bounces for now.
files
Allow to specify additional cc and bcc emails (not roundup users)... http://hg.code.sf.net:8000/p/roundup/code/#changeset-29576edb45d5d832f6396dea50ca0cfc38984be6 Ralf Schlatterbeck schlatterbeck@users.sourceforge.net 2011-05-23T12:15:23+00:00 2011-05-23T12:15:23+00:00
changeset 29576edb45d5
branch
bookmark
tag
user Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
description Allow to specify additional cc and bcc emails (not roundup users)...

...for nosymessage used by the nosyreaction reactor.
files
Fix first part of Password handling security issue2550688 http://hg.code.sf.net:8000/p/roundup/code/#changeset-1613754d26466c96b3fbf6a74ae5db2f944df1c9 Ralf Schlatterbeck schlatterbeck@users.sourceforge.net 2011-04-14T12:24:59+00:00 2011-04-14T12:24:59+00:00
changeset 1613754d2646
branch
bookmark
tag
user Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
description Fix first part of Password handling security issue2550688

(thanks Joseph Myers for reporting and Eli Collins for fixing)

Small change against original patch: We still accept plaintext passwords
(in known_schemes) when parsing encrypted password (e.g. from database).
This way existing databases with plaintext passwords continue to work (I
don't know of any, this would need patching on the users side) and all
regression tests pass.
files
python2.3 compatibility fixes http://hg.code.sf.net:8000/p/roundup/code/#changeset-9d37875416c349dc06801d9289e68ea6cfb47800 Ralf Schlatterbeck schlatterbeck@users.sourceforge.net 2010-10-21T20:31:13+00:00 2010-10-21T20:31:13+00:00
changeset 9d37875416c3
branch
bookmark
tag
user Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
description python2.3 compatibility fixes
files
fix py2.4 compatibility http://hg.code.sf.net:8000/p/roundup/code/#changeset-25085aec7d5ab0474a07aa7dd743cc58a9aedc87 Richard Jones richard@users.sourceforge.net 2010-10-06T23:37:29+00:00 2010-10-06T23:37:29+00:00
changeset 25085aec7d5a
branch
bookmark
tag
user Richard Jones <richard@users.sourceforge.net>
description fix py2.4 compatibility
files
Mail gateway fixes and improvements. http://hg.code.sf.net:8000/p/roundup/code/#changeset-f1affb6b7a08a255236210659200ea83383b4132 Ralf Schlatterbeck schlatterbeck@users.sourceforge.net 2010-10-05T14:24:25+00:00 2010-10-05T14:24:25+00:00
changeset f1affb6b7a08
branch
bookmark
tag
user Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
description Mail gateway fixes and improvements.

- new mailgw config item unpack_rfc822 that unpacks message attachments
of type message/rfc822 and attaches the individual parts instead of
attaching the whole message/rfc822 attachment to the roundup issue.
- Fix handling of incoming message/rfc822 attachments. These resulted in
a weird mail usage error because the email module threw a TypeError
which roundup interprets as a Reject exception. Fixes issue2550667.
Added regression tests for message/rfc822 attachments with and without
configured unpacking (mailgw unpack_rfc822, see Features above)
Thanks to Benni Bärmann for reporting.
files
Fix charset of first text-part of outgoing multipart messages... http://hg.code.sf.net:8000/p/roundup/code/#changeset-579802067547e97740b8ff321a3d5198931933e1 Ralf Schlatterbeck schlatterbeck@users.sourceforge.net 2010-10-04T12:56:37+00:00 2010-10-04T12:56:37+00:00
changeset 579802067547
branch
bookmark
tag
user Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
description Fix charset of first text-part of outgoing multipart messages...

...thanks Dirk Geschke for reporting, see
http://thread.gmane.org/gmane.comp.bug-tracking.roundup.user/10223
This also adds some regression tests to test incoming latin1 and
outgoing single- and multipart utf-8 and latin1 messages
files
- more logger fixes -- use correct hierarchical logger names... http://hg.code.sf.net:8000/p/roundup/code/#changeset-9655a1b65974dfe2d1e2270fa419a067829ef72a Ralf Schlatterbeck schlatterbeck@users.sourceforge.net 2010-09-16T07:44:50+00:00 2010-09-16T07:44:50+00:00
changeset 9655a1b65974
branch
bookmark
tag
user Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
description - more logger fixes -- use correct hierarchical logger names...

...always starting with "roundup." -- otherwise logger configuration
changed in changeset
2010-08-09T03:36:06Z!schlatterbeck@users.sourceforge.net will not work
(e.g. turning debugging on)
files
The email for the first message on an issue... http://hg.code.sf.net:8000/p/roundup/code/#changeset-887a153cedec0496f6ba5eb265b6ca71c45cca32 Richard Jones richard@users.sourceforge.net 2010-02-23T03:20:17+00:00 2010-02-23T03:20:17+00:00
changeset 887a153cedec
branch
bookmark
tag
user Richard Jones <richard@users.sourceforge.net>
description The email for the first message on an issue...

...was sometimes having its In-Reply-To set to itself (thanks Eric
Kow).

Also fix roundupdb IssueClass code to use the variable "issueid" instead of
the braindead "nodeid".
files
make some more memorydb tests pass http://hg.code.sf.net:8000/p/roundup/code/#changeset-0e33bf5571dc793e578d0f0290f254aafec2aad0 Richard Jones richard@users.sourceforge.net 2010-02-05T05:10:52+00:00 2010-02-05T05:10:52+00:00
changeset 0e33bf5571dc
branch
bookmark
tag
user Richard Jones <richard@users.sourceforge.net>
description make some more memorydb tests pass
files
Attempt to generate more human-readable addresses in email http://hg.code.sf.net:8000/p/roundup/code/#changeset-94ee533613ac4d913231f9037fb9b6177425d9bd Richard Jones richard@users.sourceforge.net 2010-02-01T03:59:02+00:00 2010-02-01T03:59:02+00:00
changeset 94ee533613ac
branch
bookmark
tag
user Richard Jones <richard@users.sourceforge.net>
description Attempt to generate more human-readable addresses in email
files
- small typo http://hg.code.sf.net:8000/p/roundup/code/#changeset-236939e4137b9a5fcc3f24a413bb41e74b136a93 Ralf Schlatterbeck schlatterbeck@users.sourceforge.net 2009-11-30T21:17:14+00:00 2009-11-30T21:17:14+00:00
changeset 236939e4137b
branch
bookmark
tag
user Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
description - small typo

- fix roundup_server if no host header is given in http request
files
Fix security-problem: If user hasn't permission on a message... http://hg.code.sf.net:8000/p/roundup/code/#changeset-7275e3dec0e016dc0e1fce587a5d6cbc6b0becca Ralf Schlatterbeck schlatterbeck@users.sourceforge.net 2009-11-30T14:45:44+00:00 2009-11-30T14:45:44+00:00
changeset 7275e3dec0e0
branch
bookmark
tag
user Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
description Fix security-problem: If user hasn't permission on a message...

...(notably files and content properties) and is on the nosy list, the
content was sent via email. We now check that user has permission on
the message content and files properties. Also add a regression test
for this.
files
fix construction of individual messages to nosy recipents with attachments http://hg.code.sf.net:8000/p/roundup/code/#changeset-7baf1925c4c1ab25f88f6be70bafcd70c7c6cbd0 Richard Jones richard@users.sourceforge.net 2009-07-20T06:24:52+00:00 2009-07-20T06:24:52+00:00
changeset 7baf1925c4c1
branch
bookmark
tag
user Richard Jones <richard@users.sourceforge.net>
description fix construction of individual messages to nosy recipents with attachments
files
Fix issue2550565. http://hg.code.sf.net:8000/p/roundup/code/#changeset-d5cd6f440396215a37b36f4192bccc8bb8dc8632 Stefan Seefeld stefan@seefeld.name 2009-07-14T18:21:06+00:00 2009-07-14T18:21:06+00:00
changeset d5cd6f440396
branch
bookmark
tag
user Stefan Seefeld <stefan@seefeld.name>
description Fix issue2550565.
files
bug introduced in the migration to the email package (issue 2550531) http://hg.code.sf.net:8000/p/roundup/code/#changeset-da682f38bad332d900a4ed6756fc901fae8823d3 Richard Jones richard@users.sourceforge.net 2009-03-17T22:56:38+00:00 2009-03-17T22:56:38+00:00
changeset da682f38bad3
branch
bookmark
tag
user Richard Jones <richard@users.sourceforge.net>
description bug introduced in the migration to the email package (issue 2550531)
files
migrate from MimeWriter to email http://hg.code.sf.net:8000/p/roundup/code/#changeset-4b0ddce43d08f5e8f1ca743463d453eac5de8bbe Richard Jones richard@users.sourceforge.net 2009-03-12T05:55:16+00:00 2009-03-12T05:55:16+00:00
changeset 4b0ddce43d08
branch
bookmark
tag
user Richard Jones <richard@users.sourceforge.net>
description migrate from MimeWriter to email
files
Enhance and simplify logging. http://hg.code.sf.net:8000/p/roundup/code/#changeset-ef0b4396888a1b21d9843aa358639c445ca239f2 Stefan Seefeld stefan@seefeld.name 2009-02-20T04:38:34+00:00 2009-02-20T04:38:34+00:00
changeset ef0b4396888a
branch
bookmark
tag
user Stefan Seefeld <stefan@seefeld.name>
description Enhance and simplify logging.
files