annotate website/issues/html/_generic.404.html @ 5548:fea11d05110e

Avoid errors from selecting "no selection" on multilink (issue2550722). As discussed in issue 2550722 there are various cases where selecting "no selection" on a multilink can result in inappropriate errors from Roundup: * If selecting "no selection" produces a null edit (a value was set in the multilink in an edit with an error, then removed again, along with all other changes, in the next form submission), so the page is rendered from the form contents including the "-<id>" value for "no selection" for the multilink. * If creating an item with a nonempty value for a multilink has an error, and the resubmission changes that multilink to "no selection" (and this in turn has subcases, according to whether the creation then succeeds or fails on the resubmission, which need fixes in different places in the Roundup code). All of these cases have in common that it is expected and OK to have a "-<id>" value for a submission for a multilink when <id> is not set in that multilink in the database (because the original attempt to set <id> in that multilink had an error), so the hyperdb.py logic to give an error in that case is thus removed. In the subcase of the second case where the resubmission with "no selection" has an error, the templating code tries to produce a menu entry for the "-<id>" multilink value, which also results in an error, hence the templating.py change to ignore such values in the list for a multilink.
author Joseph Myers <jsm@polyomino.org.uk>
date Thu, 27 Sep 2018 11:33:01 +0000
parents 8d595c5486c0
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
5278
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
1 <!-- dollarId: issue.item,v 1.4 2001/08/03 01:19:43 richard Exp dollar-->
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
2 <tal:block metal:use-macro="templates/page/macros/icing">
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
3 <title metal:fill-slot="head_title">
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
4 Item Not Found
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
5 </title>
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
6 <tal:block metal:fill-slot="body_title">
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
7 Item Not Found
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
8 </tal:block>
4024
c2d0d3e9099d svn repository setup
Stefan Seefeld <stefan@users.sourceforge.net>
parents:
diff changeset
9
5278
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
10 <td class="content" metal:fill-slot="content">
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
11 There is no <span tal:content="context/_classname" /> with id
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
12 <span tal:content="context/id"/>
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
13 </td>
8d595c5486c0 Update from current classic template. Change includes page
John Rouillard <rouilj@ieee.org>
parents: 4024
diff changeset
14 </tal:block>

Roundup Issue Tracker: http://roundup-tracker.org/