Mercurial > p > roundup > code
annotate website/issues/detectors/newissuecopy.py @ 5548:fea11d05110e
Avoid errors from selecting "no selection" on multilink (issue2550722).
As discussed in issue 2550722 there are various cases where selecting
"no selection" on a multilink can result in inappropriate errors from
Roundup:
* If selecting "no selection" produces a null edit (a value was set in
the multilink in an edit with an error, then removed again, along
with all other changes, in the next form submission), so the page is
rendered from the form contents including the "-<id>" value for "no
selection" for the multilink.
* If creating an item with a nonempty value for a multilink has an
error, and the resubmission changes that multilink to "no selection"
(and this in turn has subcases, according to whether the creation
then succeeds or fails on the resubmission, which need fixes in
different places in the Roundup code).
All of these cases have in common that it is expected and OK to have a
"-<id>" value for a submission for a multilink when <id> is not set in
that multilink in the database (because the original attempt to set
<id> in that multilink had an error), so the hyperdb.py logic to give
an error in that case is thus removed. In the subcase of the second
case where the resubmission with "no selection" has an error, the
templating code tries to produce a menu entry for the "-<id>"
multilink value, which also results in an error, hence the
templating.py change to ignore such values in the list for a
multilink.
| author | Joseph Myers <jsm@polyomino.org.uk> |
|---|---|
| date | Thu, 27 Sep 2018 11:33:01 +0000 |
| parents | 35ea9b1efc14 |
| children |
| rev | line source |
|---|---|
|
4354
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
1 from roundup import roundupdb |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
2 |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
3 def newissuecopy(db, cl, nodeid, oldvalues): |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
4 ''' Copy a message about new issues to a team address. |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
5 ''' |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
6 # so use all the messages in the create |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
7 change_note = cl.generateCreateNote(nodeid) |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
8 |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
9 # send a copy to the nosy list |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
10 for msgid in cl.get(nodeid, 'messages'): |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
11 try: |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
12 # note: last arg must be a list |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
13 cl.send_message(nodeid, msgid, change_note, |
|
5277
b580f61929e2
Removing richard from notification list. Verified that
John Rouillard <rouilj@ieee.org>
parents:
5248
diff
changeset
|
14 ['roundup-devel@lists.sourceforge.net']) |
|
5248
198b6e810c67
Use Python-3-compatible 'as' syntax for except statements
Eric S. Raymond <esr@thyrsus.com>
parents:
4376
diff
changeset
|
15 except roundupdb.MessageSendError as message: |
|
5378
35ea9b1efc14
Python 3 preparation: "raise" syntax.
Joseph Myers <jsm@polyomino.org.uk>
parents:
5277
diff
changeset
|
16 raise roundupdb.DetectorError(message) |
|
4354
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
17 |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
18 def init(db): |
|
81a9eda2a798
I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
19 db.issue.react('create', newissuecopy) |
|
5277
b580f61929e2
Removing richard from notification list. Verified that
John Rouillard <rouilj@ieee.org>
parents:
5248
diff
changeset
|
20 #SHA: 6ed003c947e1f9df148f8f4500b7c2e68a45229b |
