Mercurial > p > roundup > code
annotate website/issues/html/query.item.html @ 6823:fe0091279f50
Refactor session db logging and key generation for sessions/otks
While I was working on the redis sessiondb stuff, I noticed that
log_wanrning, get_logger ... was duplicated. Also there was code to
generate a unique key for otks that was duplicated.
Changes:
creating new sessions_common.py and SessionsCommon class to provide
methods:
log_warning, log_info, log_debug, get_logger, getUniqueKey
getUniqueKey method is closer to the method used to make
session keys in client.py.
sessions_common.py now report when random_.py chooses a weak
random number generator. Removed same from rest.py.
get_logger reconciles all logging under
roundup.hyperdb.backends.<name of BasicDatabase class>
some backends used to log to root logger.
have BasicDatabase in other sessions_*.py modules inherit from
SessionCommon.
change logging to use log_* methods.
In addition:
remove unused imports reported by flake8 and other formatting
changes
modify actions.py, rest.py, templating.py to use getUniqueKey
method.
add tests for new methods
test_redis_session.py
swap out ModuleNotFoundError for ImportError to prevent crash in
python2 when redis is not present.
allow injection of username:password or just password into redis
connection URL. set pytest_redis_pw envirnment variable to password
or user:password when running test.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sun, 07 Aug 2022 01:51:11 -0400 |
| parents | 578b5294e888 |
| children |
| rev | line source |
|---|---|
|
4024
c2d0d3e9099d
svn repository setup
Stefan Seefeld <stefan@users.sourceforge.net>
parents:
diff
changeset
|
1 <!-- query.item --> |
|
5286
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
2 <span tal:condition="context/is_view_ok" tal:replace="structure |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
3 context/renderQueryForm" /> |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
4 <tal:block tal:condition="not:context/is_view_ok"> |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
5 <tal:block metal:use-macro="templates/page/macros/icing"> |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
6 <title metal:fill-slot="head_title">You can not view query</title> |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
7 <tal:block metal:fill-slot="body_title"> |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
8 You can not view query. |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
9 </tal:block> |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
10 <td class="content" metal:fill-slot="content"> |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
11 You are not allowed to view <span tal:content="context/_classname"/> |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
12 with id <span tal:content="context/id"/> |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
13 </td> |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
14 </tal:block> |
|
578b5294e888
Update to current classic config. Fixes issue with users being able to
John Rouillard <rouilj@ieee.org>
parents:
4024
diff
changeset
|
15 </tal:block> |
