Mercurial > p > roundup > code
annotate roundup/anypy/cookie_.py @ 6823:fe0091279f50
Refactor session db logging and key generation for sessions/otks
While I was working on the redis sessiondb stuff, I noticed that
log_wanrning, get_logger ... was duplicated. Also there was code to
generate a unique key for otks that was duplicated.
Changes:
creating new sessions_common.py and SessionsCommon class to provide
methods:
log_warning, log_info, log_debug, get_logger, getUniqueKey
getUniqueKey method is closer to the method used to make
session keys in client.py.
sessions_common.py now report when random_.py chooses a weak
random number generator. Removed same from rest.py.
get_logger reconciles all logging under
roundup.hyperdb.backends.<name of BasicDatabase class>
some backends used to log to root logger.
have BasicDatabase in other sessions_*.py modules inherit from
SessionCommon.
change logging to use log_* methods.
In addition:
remove unused imports reported by flake8 and other formatting
changes
modify actions.py, rest.py, templating.py to use getUniqueKey
method.
add tests for new methods
test_redis_session.py
swap out ModuleNotFoundError for ImportError to prevent crash in
python2 when redis is not present.
allow injection of username:password or just password into redis
connection URL. set pytest_redis_pw envirnment variable to password
or user:password when running test.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sun, 07 Aug 2022 01:51:11 -0400 |
| parents | 4cb860c33b37 |
| children | 07ce4e4110f5 |
| rev | line source |
|---|---|
|
4362
74476eaac38a
more modernisation
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
1 |
|
74476eaac38a
more modernisation
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
2 try: |
|
4996
dfd0bcc947e5
Add comments about supported anypy python versions
John Kristensen <john@jerrykan.com>
parents:
4362
diff
changeset
|
3 # Python 3+ |
|
4362
74476eaac38a
more modernisation
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
4 from http import cookies as Cookie |
|
74476eaac38a
more modernisation
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
5 from http.cookies import CookieError, BaseCookie, SimpleCookie |
|
74476eaac38a
more modernisation
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
6 from http.cookies import _getdate as get_cookie_date |
|
6024
4cb860c33b37
flake8 replace bare except with except ImportError.
John Rouillard <rouilj@ieee.org>
parents:
4996
diff
changeset
|
7 except ImportError: |
|
4996
dfd0bcc947e5
Add comments about supported anypy python versions
John Kristensen <john@jerrykan.com>
parents:
4362
diff
changeset
|
8 # Python 2.5-2.7 |
|
4362
74476eaac38a
more modernisation
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
9 from Cookie import CookieError, BaseCookie, SimpleCookie |
|
74476eaac38a
more modernisation
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
10 from Cookie import _getdate as get_cookie_date |
