Mercurial > p > roundup > code
annotate website/issues/html/home.about.html @ 8185:e84d4585b16d
fix(web): issue2551356. Add etag header for not-modified (304) request.
When a 304 is returned to a conditional request for a static file,
print an ETag for the response.
ETag was always sent with a 200 response.
This also adds initial support for if-none-match conditional requests
for static files.
Changes:
Refactors the if-modified-since code out to a method.
It moves a file stat call from serve_static_file to _serve_file
so that an etag can be generated by both serve_static_file and
serve_file which call _serve_file.
Tests added. This does not test the codepath where serve_file pulls
content from the database rather than from a local file on disk.
Test mocking _serve_file changed to account for 5th argument to serve_file
BREAKING CHANGE:
function signature for client.py-Client::_serve_file() now has 5 not 4
parameters (added etag param). Since this is a "hidden" method I am
not too worried about it.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Tue, 10 Dec 2024 16:06:13 -0500 |
| parents | 4155ed7f00f4 |
| children |
| rev | line source |
|---|---|
| 6246 | 1 <!-- dollarId: issue.index,v 1.2 2001/07/29 04:07:37 richard Exp dollar--> |
| 2 | |
| 3 <tal:block metal:use-macro="templates/page/macros/icing"> | |
| 4 | |
| 5 <title metal:fill-slot="head_title" i18n:translate="" > | |
| 6 About this Tracker | |
| 7 </title> | |
| 8 <tal:block metal:fill-slot="body_title" i18n:translate=""> | |
| 9 About this Tracker | |
| 10 </tal:block> | |
| 11 | |
| 12 <div class="content" metal:fill-slot="content"> | |
| 13 | |
| 14 <span tal:condition="not:python:request.user.hasRole('Admin')" | |
| 15 tal:omit-tag="python:1" i18n:translate=""> | |
| 16 Please login with your username and password to find out about | |
| 17 this tracker. | |
| 18 </span> | |
| 19 | |
| 20 <div tal:condition="python:request.user.hasRole('Admin')" | |
| 21 tal:omit-tag="python:1" i18n:translate=""> | |
| 22 <div tal:replace="structure python:utils.AboutPage(db)"></div> | |
| 23 </div> | |
| 24 </div> | |
| 25 | |
| 26 </tal:block> |