Mercurial > p > roundup > code
annotate roundup/dist/command/install_lib.py @ 8185:e84d4585b16d
fix(web): issue2551356. Add etag header for not-modified (304) request.
When a 304 is returned to a conditional request for a static file,
print an ETag for the response.
ETag was always sent with a 200 response.
This also adds initial support for if-none-match conditional requests
for static files.
Changes:
Refactors the if-modified-since code out to a method.
It moves a file stat call from serve_static_file to _serve_file
so that an etag can be generated by both serve_static_file and
serve_file which call _serve_file.
Tests added. This does not test the codepath where serve_file pulls
content from the database rather than from a local file on disk.
Test mocking _serve_file changed to account for 5th argument to serve_file
BREAKING CHANGE:
function signature for client.py-Client::_serve_file() now has 5 not 4
parameters (added etag param). Since this is a "hidden" method I am
not too worried about it.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Tue, 10 Dec 2024 16:06:13 -0500 |
| parents | 42bf0a707763 |
| children |
| rev | line source |
|---|---|
| 4516 | 1 from roundup.dist.command.build import build_message_files, check_manifest |
|
6647
42bf0a707763
issue2551183 - Replace references to distutils in roundup/dist/command
John Rouillard <rouilj@ieee.org>
parents:
4516
diff
changeset
|
2 from setuptools.command.install_lib import install_lib as base |
| 4516 | 3 |
| 4 class install_lib(base): | |
| 5 | |
| 6 def run(self): | |
| 7 check_manifest() | |
| 8 build_message_files(self) | |
| 9 base.run(self) |