annotate test/test_mailer.py @ 7968:d7e79f8eb943

issue2551350 - Python changes for 3.12 with roundup 2.3.0 mailer.py Fix due to change in smtplib.SMTP.starttls() signature. As of 3.3 it can use an optional ssl context argument for certificates/keys. In 3.12 it dropped legacy support for specifing cert/key files as arguments and requires a context. I modified Andrew's original patch to initialize SSLContext with ssl.PROTOCOL_TLS_CLIENT. If there is a cert file specified, enable check_hostname - verify that the cert supplied by the server matches the hostname we supplied. If there is no cert file call load_default_certs() Also opened issue2551351 to look into more SMTP ssmtp tightening. We also should have an option in Roundup to use TLS/SSL (smtps) without using starttls. Note that this code is untested by the test suite due to the need to setup an SMTP server with STARTTLS support. issue2551351 has some notes on this.
author John Rouillard <rouilj@ieee.org>
date Wed, 15 May 2024 00:08:05 -0400
parents 95a366d46065
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
5248
198b6e810c67 Use Python-3-compatible 'as' syntax for except statements
Eric S. Raymond <esr@thyrsus.com>
parents: 5037
diff changeset
1 #-*- encoding: utf-8 -*-
4338
94ee533613ac Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
2 import unittest
94ee533613ac Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
3
94ee533613ac Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
4 from roundup import mailer
94ee533613ac Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
5
94ee533613ac Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
6 class EncodingTestCase(unittest.TestCase):
4520
182d8c41a3aa Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents: 4338
diff changeset
7 def testEncoding(self):
5794
95a366d46065 Replace deprecated assertEquals with assertEqual and failUnlessRaises
John Rouillard <rouilj@ieee.org>
parents: 5458
diff changeset
8 a = lambda n, a, c, o: self.assertEqual(mailer.nice_sender_header(n,
4338
94ee533613ac Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
9 a, c), o)
4520
182d8c41a3aa Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents: 4338
diff changeset
10 a('ascii', 'ascii@test.com', 'iso8859-1', 'ascii <ascii@test.com>')
182d8c41a3aa Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents: 4338
diff changeset
11 a(u'café', 'ascii@test.com', 'iso8859-1',
182d8c41a3aa Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents: 4338
diff changeset
12 '=?iso8859-1?q?caf=E9?= <ascii@test.com>')
5458
bc2e682e0305 fixed encoding issues in mailer
Christof Meerwald <cmeerw@cmeerw.org>
parents: 5248
diff changeset
13 a(u'café', 'ascii@test.com', 'utf-8',
bc2e682e0305 fixed encoding issues in mailer
Christof Meerwald <cmeerw@cmeerw.org>
parents: 5248
diff changeset
14 '=?utf-8?b?Y2Fmw6k=?= <ascii@test.com>')
4520
182d8c41a3aa Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents: 4338
diff changeset
15 a('as"ii', 'ascii@test.com', 'iso8859-1', '"as\\"ii" <ascii@test.com>')
4338
94ee533613ac Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
16
94ee533613ac Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
17 # vim: set et sts=4 sw=4 :

Roundup Issue Tracker: http://roundup-tracker.org/