Mercurial > p > roundup > code

annotate test/test_rfc2822.py @ 4880:ca692423e401

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Different approach to fix XSS in issue2550817 Encapsulate the error/ok message append method as add_ok_message and add_error_message. The new approach escapes the messages when appending -- at a point in the code where we still know where the message comes from. Escaping is the default but can bei turned off. This also fixes issue2550836 where certain messages may contain links. Another advantage of the new fix is that users don't need to change installed trackers and are secure by default.
author Ralf Schlatterbeck <rsc@runtux.com>
date Mon, 31 Mar 2014 18:19:23 +0200
parents 97f9fc0bc0ea
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
3519
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
1 from roundup.rfc2822 import decode_header, encode_header
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
2
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
3 import unittest, time
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
4
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
5 class RFC2822TestCase(unittest.TestCase):
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
6 def testDecode(self):
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
7 src = 'Re: [it_issue3] '\
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
8 '=?ISO-8859-1?Q?Ren=E9s_[resp=3Dg=2Cstatus=3D?= '\
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
9 '=?ISO-8859-1?Q?feedback]?='
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
10 result = 'Re: [it_issue3] Ren\xc3\xa9s [resp=g,status=feedback]'
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
11 self.assertEqual(decode_header(src), result)
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
12
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
13 src = 'Re: [it_issue3]'\
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
14 ' =?ISO-8859-1?Q?Ren=E9s_[resp=3Dg=2Cstatus=3D?=' \
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
15 ' =?ISO-8859-1?Q?feedback]?='
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
16 result = 'Re: [it_issue3] Ren\xc3\xa9s [resp=g,status=feedback]'
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
17 self.assertEqual(decode_header(src), result)
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
18
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
19 def testEncode(self):
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
20 src = 'Re: [it_issue3] Ren\xc3\xa9s [status=feedback]'
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
21 result = '=?utf-8?q?Re:_[it=5Fissue3]_Ren=C3=A9s_[status=3Dfeedback]?='
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
22 self.assertEqual(encode_header(src), result)
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
23
3639
97f9fc0bc0ea Yet another rfc2822 encoding patch: '?' must be escaped.
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents: 3519
diff changeset
24 src = 'Was machen\xc3\xbc und Fragezeichen?'
97f9fc0bc0ea Yet another rfc2822 encoding patch: '?' must be escaped.
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents: 3519
diff changeset
25 result = '=?utf-8?q?Was_machen=C3=BC_und_Fragezeichen=3F?='
97f9fc0bc0ea Yet another rfc2822 encoding patch: '?' must be escaped.
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents: 3519
diff changeset
26 self.assertEqual(encode_header(src), result)
97f9fc0bc0ea Yet another rfc2822 encoding patch: '?' must be escaped.
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents: 3519
diff changeset
27
3519
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
28 def test_suite():
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
29 suite = unittest.TestSuite()
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
30 suite.addTest(unittest.makeSuite(RFC2822TestCase))
0c34f5a116ef additional header encode/decode fixes
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
31 return suite
Roundup Issue Tracker: http://roundup-tracker.org/