annotate website/issues/detectors/newissuecopy.py @ 6433:c1d3fbcdbfbd

issue2551142 - Import of retired node ... unique constraint failure. Title: Import of retired node with username after active node fails with unique constraint failure. More fixes needed for mysql and postgresql. mysql: add unique constraint for (keyvalue, __retired__) when creating class in the database. On schema change if class is changed, remove the unique constraint too. upgrade version of rdbms database from 5 to 6 to add constraint to all version 5 databases that were created as version 5 and didn't get the unique constraint. Make no changes on version 5 databases upgraded from version 4, the upgrade process to 5 added the constraint. Make no changes to other databases (sqlite, postgres) during upgrade from version 5 to 6. postgres: Handle the exception raised on unique constraint violation. The exception invalidates the database connection so it can't be used to recover from the exception. Added two new database methods: checkpoint_data - performs a db.commit under postgres does nothing on other backends restore_connection_on_error - does a db.rollback on postgres, does nothing on other backends with the rollback() done on the connection I can use the database connection to fixup the import that failed on the unique constraint. This makes postgres slower but without the commit after every imported object, the rollback will delete all the entries done up to this point. Trying to figure out how to make the caller do_import batch and recover from this failure is beyond me. Also dismissed having to process the export csv file before importing. Pushing that onto a user just seems wrong. Also since import/export isn't frequently done the lack of surprise on having a failing import and reduced load/frustration for the user seems worth it. Also the import can be run in verbose mode where it prints out a row as it is processed, so it may take a while, ut the user can get feedback. db_test-base.py: add test for upgrade from 5 to 6.
author John Rouillard <rouilj@ieee.org>
date Thu, 10 Jun 2021 12:52:05 -0400
parents 35ea9b1efc14
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
4354
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
1 from roundup import roundupdb
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
2
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
3 def newissuecopy(db, cl, nodeid, oldvalues):
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
4 ''' Copy a message about new issues to a team address.
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
5 '''
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
6 # so use all the messages in the create
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
7 change_note = cl.generateCreateNote(nodeid)
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
8
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
9 # send a copy to the nosy list
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
10 for msgid in cl.get(nodeid, 'messages'):
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
11 try:
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
12 # note: last arg must be a list
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
13 cl.send_message(nodeid, msgid, change_note,
5277
b580f61929e2 Removing richard from notification list. Verified that
John Rouillard <rouilj@ieee.org>
parents: 5248
diff changeset
14 ['roundup-devel@lists.sourceforge.net'])
5248
198b6e810c67 Use Python-3-compatible 'as' syntax for except statements
Eric S. Raymond <esr@thyrsus.com>
parents: 4376
diff changeset
15 except roundupdb.MessageSendError as message:
5378
35ea9b1efc14 Python 3 preparation: "raise" syntax.
Joseph Myers <jsm@polyomino.org.uk>
parents: 5277
diff changeset
16 raise roundupdb.DetectorError(message)
4354
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
17
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
18 def init(db):
81a9eda2a798 I need to know when new issues are created
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
19 db.issue.react('create', newissuecopy)
5277
b580f61929e2 Removing richard from notification list. Verified that
John Rouillard <rouilj@ieee.org>
parents: 5248
diff changeset
20 #SHA: 6ed003c947e1f9df148f8f4500b7c2e68a45229b

Roundup Issue Tracker: http://roundup-tracker.org/