Mercurial > p > roundup > code
annotate tools/migrate-queries.py @ 6433:c1d3fbcdbfbd
issue2551142 - Import of retired node ... unique constraint failure.
Title: Import of retired node with username after active node fails
with unique constraint failure.
More fixes needed for mysql and postgresql.
mysql: add unique constraint for (keyvalue, __retired__) when
creating class in the database.
On schema change if class is changed, remove the unique
constraint too.
upgrade version of rdbms database from 5 to 6 to add constraint
to all version 5 databases that were created as version 5
and didn't get the unique constraint. Make no changes
on version 5 databases upgraded from version 4, the upgrade
process to 5 added the constraint. Make no changes
to other databases (sqlite, postgres) during upgrade from
version 5 to 6.
postgres: Handle the exception raised on unique constraint violation.
The exception invalidates the database connection so it
can't be used to recover from the exception.
Added two new database methods:
checkpoint_data - performs a db.commit under postgres
does nothing on other backends
restore_connection_on_error - does a db.rollback on
postgres, does nothing on other
backends
with the rollback() done on the connection I can use the
database connection to fixup the import that failed on the
unique constraint. This makes postgres slower but without the
commit after every imported object, the rollback will delete
all the entries done up to this point.
Trying to figure out how to make the caller do_import batch
and recover from this failure is beyond me.
Also dismissed having to process the export csv file before
importing. Pushing that onto a user just seems wrong. Also
since import/export isn't frequently done the lack of
surprise on having a failing import and reduced
load/frustration for the user seems worth it. Also the import
can be run in verbose mode where it prints out a row as it is
processed, so it may take a while, ut the user can get
feedback.
db_test-base.py: add test for upgrade from 5 to 6.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Thu, 10 Jun 2021 12:52:05 -0400 |
| parents | 64b05e24dbd8 |
| children | fed0f839c260 |
| rev | line source |
|---|---|
|
3346
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
1 #! /usr/bin/env python |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
2 ''' |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
3 migrate-queries <instance-home> [<instance-home> *] |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
4 |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
5 Migrate old queries in the specified instances to Roundup 0.6.0+ by |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
6 removing the leading ? from their URLs. 0.6.0+ queries do not carry a |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
7 leading ?; it is added by the 0.6.0 templating, so old queries lead |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
8 to query URLs with a double leading ?? and a consequent 404 Not Found. |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
9 ''' |
|
5376
64b05e24dbd8
Python 3 preparation: convert print to a function.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4781
diff
changeset
|
10 from __future__ import print_function |
|
3346
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
11 __author__ = 'James Kew <jkew@mediabright.co.uk>' |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
12 |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
13 import sys |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
14 import roundup.instance |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
15 |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
16 if len(sys.argv) == 1: |
|
5376
64b05e24dbd8
Python 3 preparation: convert print to a function.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4781
diff
changeset
|
17 print(__doc__) |
|
3346
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
18 sys.exit(1) |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
19 |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
20 # Iterate over all instance homes specified in argv. |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
21 for home in sys.argv[1:]: |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
22 # Do some basic exception handling to catch bad arguments. |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
23 try: |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
24 instance = roundup.instance.open(home) |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
25 except: |
|
5376
64b05e24dbd8
Python 3 preparation: convert print to a function.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4781
diff
changeset
|
26 print('Cannot open instance home directory %s!' % home) |
|
3346
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
27 continue |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
28 |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
29 db = instance.open('admin') |
| 4781 | 30 db.tx_Source = "cli" |
|
3346
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
31 |
|
5376
64b05e24dbd8
Python 3 preparation: convert print to a function.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4781
diff
changeset
|
32 print('Migrating active queries in %s (%s):'%( |
|
64b05e24dbd8
Python 3 preparation: convert print to a function.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4781
diff
changeset
|
33 instance.config.TRACKER_NAME, home)) |
|
3346
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
34 for query in db.query.list(): |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
35 url = db.query.get(query, 'url') |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
36 if url[0] == '?': |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
37 url = url[1:] |
|
5376
64b05e24dbd8
Python 3 preparation: convert print to a function.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4781
diff
changeset
|
38 print(' Migrating query%s (%s)'%(query, |
|
64b05e24dbd8
Python 3 preparation: convert print to a function.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4781
diff
changeset
|
39 db.query.get(query, 'name'))) |
|
3346
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
40 db.query.set(query, url=url) |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
41 |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
42 db.commit() |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
43 db.close() |
|
a133f03df238
consistency in file formats
Anthony Baxter <anthonybaxter@users.sourceforge.net>
parents:
1850
diff
changeset
|
44 |
