Mercurial > p > roundup > code
annotate roundup/actions.py @ 5543:bc3e00a3d24b
MySQL backend fixes for Python 3.
With Python 2, text sent to and from MySQL is treated as bytes in
Python. The database may be recorded by MySQL as having some other
encoding (latin1 being the default in some MySQL versions - Roundup
does not set an encoding explicitly, unlike in back_postgresql), but
as long as MySQL's notion of the connection encoding agrees with its
notion of the database encoding, no conversions actually take place
and the bytes are stored and returned as-is.
With Python 3, text sent to and from MySQL is treated as Python
Unicode strings. When the database and connection encoding is latin1,
that means the bytes stored in the database under Python 2 are
interpreted as latin1 and converted from that to Unicode, producing
incorrect results for any non-ASCII characters; furthermore, if trying
to store new non-ASCII data in the database under Python 3, any
non-latin1 characters produce errors.
This patch arranges for both the connection and database character
sets to be UTF-8 when using Python 3, and documents a need to export
and import the database when moving from Python 2 to Python 3 with
this backend.
| author | Joseph Myers <jsm@polyomino.org.uk> |
|---|---|
| date | Sun, 16 Sep 2018 16:19:20 +0000 |
| parents | a7541077cf12 |
| children | ed02a1e0aa5d |
| rev | line source |
|---|---|
| 4083 | 1 # |
| 2 # Copyright (C) 2009 Stefan Seefeld | |
| 3 # All rights reserved. | |
| 4 # For license terms see the file COPYING.txt. | |
| 5 # | |
| 6 | |
|
5071
a7541077cf12
Remove 'import *' statement from actions.py
John Kristensen <john@jerrykan.com>
parents:
4357
diff
changeset
|
7 from roundup.exceptions import Unauthorised |
| 4083 | 8 from roundup import hyperdb |
| 9 from roundup.i18n import _ | |
| 10 | |
| 11 class Action: | |
| 12 def __init__(self, db, translator): | |
| 13 self.db = db | |
| 14 self.translator = translator | |
| 15 | |
| 16 def handle(self, *args): | |
| 17 """Action handler procedure""" | |
| 18 raise NotImplementedError | |
| 19 | |
| 20 def execute(self, *args): | |
| 21 """Execute the action specified by this object.""" | |
| 22 | |
| 23 self.permission(*args) | |
| 24 return self.handle(*args) | |
| 25 | |
| 26 | |
| 27 def permission(self, *args): | |
| 28 """Check whether the user has permission to execute this action. | |
| 29 | |
| 30 If not, raise Unauthorised.""" | |
| 31 | |
| 32 pass | |
| 33 | |
| 34 | |
| 35 def gettext(self, msgid): | |
| 36 """Return the localized translation of msgid""" | |
| 37 return self.translator.gettext(msgid) | |
| 38 | |
| 39 | |
| 40 _ = gettext | |
| 41 | |
| 42 | |
| 43 class Retire(Action): | |
| 44 | |
| 45 def handle(self, designator): | |
| 46 | |
| 47 classname, itemid = hyperdb.splitDesignator(designator) | |
| 48 | |
| 49 # make sure we don't try to retire admin or anonymous | |
| 50 if (classname == 'user' and | |
| 51 self.db.user.get(itemid, 'username') in ('admin', 'anonymous')): | |
|
4357
13b3155869e0
Beginnings of a big code cleanup / modernisation to make 2to3 happy
Richard Jones <richard@users.sourceforge.net>
parents:
4125
diff
changeset
|
52 raise ValueError(self._( |
|
13b3155869e0
Beginnings of a big code cleanup / modernisation to make 2to3 happy
Richard Jones <richard@users.sourceforge.net>
parents:
4125
diff
changeset
|
53 'You may not retire the admin or anonymous user')) |
| 4083 | 54 |
| 55 # do the retire | |
| 56 self.db.getclass(classname).retire(itemid) | |
| 57 self.db.commit() | |
| 58 | |
| 59 | |
| 60 def permission(self, designator): | |
| 61 | |
| 62 classname, itemid = hyperdb.splitDesignator(designator) | |
| 63 | |
| 64 if not self.db.security.hasPermission('Edit', self.db.getuid(), | |
| 65 classname=classname, itemid=itemid): | |
| 66 raise Unauthorised(self._('You do not have permission to ' | |
| 4125 | 67 'retire the %(classname)s class.')%classname) |
| 4083 | 68 |