annotate scripts/add-issue @ 5525:bb7865241f8a

Make CSV import/export compatible across Python versions (also RDBMS journals) (issue 2550976, issue 2550975). The roundup-admin export and import commands are used for migrating between different database backends. It is desirable that they should be usable also for migrations between Python 2 and Python 3, and in some cases (e.g. with the anydbm backend) this may be required. To be usable for such migrations, the format of the generated CSV files needs to be stable, meaning the same as currently used with Python 2. The export process uses repr() to produce the fields in the CSV files and eval() to convert them back to Python data structures. repr() of strings with non-ASCII characters produces different results for Python 2 and Python 3. This patch adds repr_export and eval_import functions to roundup/anypy/strings.py which provide the required operations that are just repr() and eval() in Python 2, but are more complicated in Python 3 to use data representations compatible with Python 2. These functions are then used in the required places for export and import. repr() and eval() are also used in storing the dict of changed values in the journal for the RDBMS backends. It is similarly desirable that the database be compatible between Python 2 and Python 3, so that export and import do not need to be used for a migration between Python versions for non-anydbm back ends. Thus, this patch changes rdbms_common.py in the places involved in storing journals in the database, not just in those involved in import/export. Given this patch, import/export with non-ASCII characters appear based on some limited testing to work across Python versions, and an instance using the sqlite backend appears to be compatible between Python versions without needing import/export, *if* the sessions/otks databases (which use anydbm) are deleted when changing Python version.
author Joseph Myers <jsm@polyomino.org.uk>
date Sun, 02 Sep 2018 23:48:04 +0000
parents c75defc1c2f0
children 9c3ec0a5c7fc
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1626
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
1 #! /usr/bin/env python
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
2 '''
1627
e029d625c8f1 minor usage doc tweak
Richard Jones <richard@users.sourceforge.net>
parents: 1626
diff changeset
3 Usage: %s <tracker home> <priority> <issue title>
1626
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
4
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
5 Create a new issue in the given tracker. Input is taken from STDIN to
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
6 create the initial issue message (which may be empty). Issues will be
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
7 created as the current user (%s) if they exist as a Roundup
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
8 user, or "admin" otherwise.
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
9 '''
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
10
5412
c75defc1c2f0 Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents: 4781
diff changeset
11 from __future__ import print_function
1626
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
12 import sys, os, pwd
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
13
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
14 from roundup import instance, mailgw, date
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
15
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
16 # open the instance
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
17 username = pwd.getpwuid(os.getuid())[0]
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
18 if len(sys.argv) < 3:
5412
c75defc1c2f0 Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents: 4781
diff changeset
19 print("Error: Not enough arguments")
c75defc1c2f0 Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents: 4781
diff changeset
20 print(__doc__.strip()%(sys.argv[0], username))
1626
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
21 sys.exit(1)
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
22 tracker_home = sys.argv[1]
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
23 issue_priority = sys.argv[2]
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
24 issue_title = ' '.join(sys.argv[3:])
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
25
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
26 # get the message, if any
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
27 message_text = sys.stdin.read().strip()
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
28
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
29 # open the tracker
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
30 tracker = instance.open(tracker_home)
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
31 db = tracker.open('admin')
4781
6e9b9743de89 Implementation for:
John Rouillard <rouilj@ieee.org>
parents: 4570
diff changeset
32 db.tx_Source = "cli"
1626
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
33 uid = db.user.lookup('admin')
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
34 try:
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
35 # try to open the tracker as the current user
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
36 uid = db.user.lookup(username)
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
37 db.close()
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
38 db = tracker.open(username)
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
39 except KeyError:
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
40 pass
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
41
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
42 try:
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
43
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
44 # handle the message
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
45 messages = []
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
46 if message_text:
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
47 summary, x = mailgw.parseContent(message_text, 0, 0)
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
48 msg = db.msg.create(content=message_text, summary=summary, author=uid,
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
49 date=date.Date())
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
50 messages = [msg]
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
51
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
52 # now create the issue
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
53 db.issue.create(title=issue_title, priority=issue_priority,
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
54 messages=messages)
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
55
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
56 db.commit()
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
57 finally:
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
58 db.close()
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
59
581aa1853a2f adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
60 # vim: set filetype=python ts=4 sw=4 et si

Roundup Issue Tracker: http://roundup-tracker.org/