annotate scripts/roundup.rc-debian @ 7752:b2dbab2b34bc

fix(refactor): multiple fixups using ruff linter; more testing. Converting to using the ruff linter and its rulesets. Fixed a number of issues. admin.py: sort imports use immutable tuples as default value markers for parameters where a None value is valid. reduced some loops to list comprehensions for performance used ternary to simplify some if statements named some variables to make them less magic (e.g. _default_savepoint_setting = 1000) fixed some tests for argument counts < 2 becomes != 2 so 3 is an error. moved exception handlers outside of loops for performance where exception handler will abort loop anyway. renamed variables called 'id' or 'dir' as they shadow builtin commands. fix translations of form _("string %s" % value) -> _("string %s") % value so translation will be looked up with the key before substitution. end dicts, tuples with a trailing comma to reduce missing comma errors if modified simplified sorted(list(self.setting.keys())) to sorted(self.setting.keys()) as sorted consumes whole list. in if conditions put compared variable on left and threshold condition on right. (no yoda conditions) multiple noqa: suppression removed unneeded noqa as lint rulesets are a bit different do_get - refactor output printing logic: Use fast return if not special formatting is requested; use isinstance with a tuple rather than two isinstance calls; cleaned up flow and removed comments on algorithm as it can be easily read from the code. do_filter, do_find - refactor output printing logic. Reduce duplicate code. do_find - renamed variable 'value' that was set inside a loop. The loop index variable was also named 'value'. do_pragma - added hint to use list subcommand if setting was not found. Replaced condition 'type(x) is bool' with 'isinstance(x, bool)' for various types. test_admin.py added testing for do_list better test coverage for do_get includes: -S and -d for multilinks, error case for -d with non-link. better testing for do_find including all output modes better testing for do_filter including all output modes fixed expected output for do_pragma that now includes hint to use pragma list if setting not found.
author John Rouillard <rouilj@ieee.org>
date Fri, 01 Mar 2024 14:53:18 -0500
parents 6e3e4f24c753
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1841
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
1 #!/bin/sh -e
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
2 #
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
3 # roundup Startup script for the roundup http server.
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
4
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
5 DESC='Roundup HTTP-Server'
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
6
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
7 BINFILE=roundup-server
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
8 EXECUTABLE=/usr/local/bin/$BINFILE
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
9 PIDFILE=/var/run/roundup/server.pid
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
10 LOGFILE=/var/log/roundup/roundup.log
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
11 TRACKERS=tttech=/tttech/org/software/roundup/tttech/
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
12 OPTIONS="-- -p 8080 -u roundup -d $PIDFILE -l $LOGFILE $TRACKERS"
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
13
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
14
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
15 test -x $EXECUTABLE || exit 0
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
16
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
17 start_stop() {
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
18 case "$1" in
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
19 start)
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
20 printf "Starting $DESC:"
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
21 start-stop-daemon --start --oknodo --quiet \
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
22 --pidfile $PIDFILE \
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
23 --exec $EXECUTABLE $OPTIONS
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
24 printf " $BINFILE"
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
25 printf ".\n"
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
26 ;;
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
27 stop)
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
28 printf "Stopping $DESC:"
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
29 start-stop-daemon --stop --oknodo --quiet \
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
30 --pidfile $PIDFILE \
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
31 --exec $EXECUTABLE $OPTIONS
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
32 printf " $BINFILE"
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
33 printf ".\n"
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
34 ;;
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
35 restart | force-reload)
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
36 start_stop stop
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
37 sleep 1
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
38 start_stop start
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
39 ;;
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
40 *)
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
41 printf "Usage: $0 {start|stop|restart|force-reload}\n" >&2
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
42 exit 1
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
43 ;;
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
44 esac
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
45 }
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
46
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
47 start_stop "$@"
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
48
24fb163ddece added Debian rc script
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
49 exit 0

Roundup Issue Tracker: http://roundup-tracker.org/