annotate roundup/anypy/cookie_.py @ 7752:b2dbab2b34bc

fix(refactor): multiple fixups using ruff linter; more testing. Converting to using the ruff linter and its rulesets. Fixed a number of issues. admin.py: sort imports use immutable tuples as default value markers for parameters where a None value is valid. reduced some loops to list comprehensions for performance used ternary to simplify some if statements named some variables to make them less magic (e.g. _default_savepoint_setting = 1000) fixed some tests for argument counts < 2 becomes != 2 so 3 is an error. moved exception handlers outside of loops for performance where exception handler will abort loop anyway. renamed variables called 'id' or 'dir' as they shadow builtin commands. fix translations of form _("string %s" % value) -> _("string %s") % value so translation will be looked up with the key before substitution. end dicts, tuples with a trailing comma to reduce missing comma errors if modified simplified sorted(list(self.setting.keys())) to sorted(self.setting.keys()) as sorted consumes whole list. in if conditions put compared variable on left and threshold condition on right. (no yoda conditions) multiple noqa: suppression removed unneeded noqa as lint rulesets are a bit different do_get - refactor output printing logic: Use fast return if not special formatting is requested; use isinstance with a tuple rather than two isinstance calls; cleaned up flow and removed comments on algorithm as it can be easily read from the code. do_filter, do_find - refactor output printing logic. Reduce duplicate code. do_find - renamed variable 'value' that was set inside a loop. The loop index variable was also named 'value'. do_pragma - added hint to use list subcommand if setting was not found. Replaced condition 'type(x) is bool' with 'isinstance(x, bool)' for various types. test_admin.py added testing for do_list better test coverage for do_get includes: -S and -d for multilinks, error case for -d with non-link. better testing for do_find including all output modes better testing for do_filter including all output modes fixed expected output for do_pragma that now includes hint to use pragma list if setting not found.
author John Rouillard <rouilj@ieee.org>
date Fri, 01 Mar 2024 14:53:18 -0500
parents 07ce4e4110f5
children d5d7ecd31864
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
4362
74476eaac38a more modernisation
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
1
74476eaac38a more modernisation
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
2 try:
4996
dfd0bcc947e5 Add comments about supported anypy python versions
John Kristensen <john@jerrykan.com>
parents: 4362
diff changeset
3 # Python 3+
4362
74476eaac38a more modernisation
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
4 from http import cookies as Cookie
74476eaac38a more modernisation
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
5 from http.cookies import CookieError, BaseCookie, SimpleCookie
74476eaac38a more modernisation
Richard Jones <richard@users.sourceforge.net>
parents:
diff changeset
6 from http.cookies import _getdate as get_cookie_date
6024
4cb860c33b37 flake8 replace bare except with except ImportError.
John Rouillard <rouilj@ieee.org>
parents: 4996
diff changeset
7 except ImportError:
4996
dfd0bcc947e5 Add comments about supported anypy python versions
John Kristensen <john@jerrykan.com>
parents: 4362
diff changeset
8 # Python 2.5-2.7
7228
07ce4e4110f5 flake8 fixes: whitespace, remove unused imports
John Rouillard <rouilj@ieee.org>
parents: 6024
diff changeset
9 from Cookie import CookieError, BaseCookie, SimpleCookie # noqa: F401
07ce4e4110f5 flake8 fixes: whitespace, remove unused imports
John Rouillard <rouilj@ieee.org>
parents: 6024
diff changeset
10 from Cookie import _getdate as get_cookie_date # noqa: F401

Roundup Issue Tracker: http://roundup-tracker.org/