Mercurial > p > roundup > code
annotate frontends/ZRoundup/__init__.py @ 7752:b2dbab2b34bc
fix(refactor): multiple fixups using ruff linter; more testing.
Converting to using the ruff linter and its rulesets. Fixed a number
of issues.
admin.py:
sort imports
use immutable tuples as default value markers for parameters where a
None value is valid.
reduced some loops to list comprehensions for performance
used ternary to simplify some if statements
named some variables to make them less magic
(e.g. _default_savepoint_setting = 1000)
fixed some tests for argument counts < 2 becomes != 2 so 3 is an
error.
moved exception handlers outside of loops for performance where
exception handler will abort loop anyway.
renamed variables called 'id' or 'dir' as they shadow builtin
commands.
fix translations of form _("string %s" % value) -> _("string %s") %
value so translation will be looked up with the key before
substitution.
end dicts, tuples with a trailing comma to reduce missing comma
errors if modified
simplified sorted(list(self.setting.keys())) to
sorted(self.setting.keys()) as sorted consumes whole list.
in if conditions put compared variable on left and threshold condition
on right. (no yoda conditions)
multiple noqa: suppression
removed unneeded noqa as lint rulesets are a bit different
do_get - refactor output printing logic: Use fast return if not
special formatting is requested; use isinstance with a tuple
rather than two isinstance calls; cleaned up flow and removed
comments on algorithm as it can be easily read from the code.
do_filter, do_find - refactor output printing logic. Reduce
duplicate code.
do_find - renamed variable 'value' that was set inside a loop. The
loop index variable was also named 'value'.
do_pragma - added hint to use list subcommand if setting was not
found. Replaced condition 'type(x) is bool' with 'isinstance(x,
bool)' for various types.
test_admin.py
added testing for do_list
better test coverage for do_get includes: -S and -d for multilinks,
error case for -d with non-link.
better testing for do_find including all output modes
better testing for do_filter including all output modes
fixed expected output for do_pragma that now includes hint to use
pragma list if setting not found.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Fri, 01 Mar 2024 14:53:18 -0500 |
| parents | d26921b851c3 |
| children |
| rev | line source |
|---|---|
|
446
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
1 # Copyright (c) 2001 Bizar Software Pty Ltd (http://www.bizarsoftware.com.au/) |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
2 # This module is free software, and you may redistribute it and/or modify |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
3 # under the same terms as Python, so long as this copyright message and |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
4 # disclaimer are retained in their original form. |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
5 # |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
6 # IN NO EVENT SHALL BIZAR SOFTWARE PTY LTD BE LIABLE TO ANY PARTY FOR |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
7 # DIRECT, INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES ARISING |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
8 # OUT OF THE USE OF THIS CODE, EVEN IF THE AUTHOR HAS BEEN ADVISED OF THE |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
9 # POSSIBILITY OF SUCH DAMAGE. |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
10 # |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
11 # BIZAR SOFTWARE PTY LTD SPECIFICALLY DISCLAIMS ANY WARRANTIES, INCLUDING, |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
12 # BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
13 # FOR A PARTICULAR PURPOSE. THE CODE PROVIDED HEREUNDER IS ON AN "AS IS" |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
14 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE, |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
15 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
16 # |
|
3655
8169e97a6f26
updated ZRoundup for Zope 2.9 (patch [SF#1511734])
Richard Jones <richard@users.sourceforge.net>
parents:
1256
diff
changeset
|
17 __version__='1.1' |
|
446
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
18 |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
19 import os |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
20 # figure where ZRoundup is installed |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
21 here = None |
|
5381
0942fe89e82e
Python 3 preparation: change "x.has_key(y)" to "y in x".
Joseph Myers <jsm@polyomino.org.uk>
parents:
5378
diff
changeset
|
22 if 'INSTANCE_HOME' in os.environ: |
|
1256
1621df560512
get ZRoundup working... still not quite right
Richard Jones <richard@users.sourceforge.net>
parents:
1096
diff
changeset
|
23 here = os.environ['INSTANCE_HOME'] |
|
446
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
24 path = os.path.join(here, 'Products', 'ZRoundup') |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
25 if not os.path.exists(path): |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
26 path = os.path.join(here, 'lib', 'python', 'Products', 'ZRoundup') |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
27 if not os.path.exists(path): |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
28 here = None |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
29 if here is None: |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
30 from __main__ import here |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
31 path = os.path.join(here, 'Products', 'ZRoundup') |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
32 if not os.path.exists(path): |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
33 path = os.path.join(here, 'lib', 'python', 'Products', 'ZRoundup') |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
34 if not os.path.exists(path): |
|
5378
35ea9b1efc14
Python 3 preparation: "raise" syntax.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4570
diff
changeset
|
35 raise ValueError("Can't determine where ZRoundup is installed") |
|
446
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
36 |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
37 # product initialisation |
|
5388
d26921b851c3
Python 3 preparation: make relative imports explicit.
Joseph Myers <jsm@polyomino.org.uk>
parents:
5381
diff
changeset
|
38 from .ZRoundup import ZRoundup, manage_addZRoundupForm, manage_addZRoundup |
|
446
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
39 def initialize(context): |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
40 context.registerClass( |
|
3655
8169e97a6f26
updated ZRoundup for Zope 2.9 (patch [SF#1511734])
Richard Jones <richard@users.sourceforge.net>
parents:
1256
diff
changeset
|
41 ZRoundup, |
|
8169e97a6f26
updated ZRoundup for Zope 2.9 (patch [SF#1511734])
Richard Jones <richard@users.sourceforge.net>
parents:
1256
diff
changeset
|
42 meta_type = 'Z Roundup', |
|
446
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
43 constructors = ( |
|
3655
8169e97a6f26
updated ZRoundup for Zope 2.9 (patch [SF#1511734])
Richard Jones <richard@users.sourceforge.net>
parents:
1256
diff
changeset
|
44 manage_addZRoundupForm, manage_addZRoundup |
|
446
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
45 ) |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
46 ) |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
47 |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
48 # set up the icon |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
49 from ImageFile import ImageFile |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
50 misc_ = { |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
51 'icon': ImageFile('icons/tick_symbol.gif', path), |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
52 } |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
53 |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
54 |
|
ea9a4ca3fb84
Added a Zope frontend for roundup.
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
55 # vim: set filetype=python ts=4 sw=4 et si |
