Mercurial > p > roundup > code
annotate test/test_init.py @ 6431:ada1edcc9132
issue2551142 - Import ... unique constraint failure.
Full title: Import of retired node with username after active node
fails with unique constraint failure.
Fix this in two ways:
1) sort export on keyname, retired status so that retired nodes for a
given keyname are before the acive node in the export file.
This stops generating a broken export.
2) handle importing a broken export by deactivating/fixing up/clearing
the active record's unique index entry temporarily. Redo the
import of the retired node and resetting the active record to active.
The fixup changes the unique index (keyvalue, __retired__) from
(keyvalue, 0) to (keyvalue, -1). Then it retries the failed import of
a retired record with keyvalue. I use -1 in case something goes wrong,
It makes the record stand out in the database allowing hand recovery
if needed. Rather than using -1 I could just use the id of the record
like a normal retirement does.
If the retry of the import fails (raises exception), reset the active
record from -1 back to 0 and raise the exception.
If it succeeds, reset the active record from -1 back to 0 and continue
the import process.
Reset __retired__ from -1 to 0 on every import. I don't think the
performance loss from resetting on every exception matters as there
should be very few exceptions. Also this makes the code more
understandable. There is no reason to leave the -1 value in place and
do a bulk rest of -1 to 0 after the class csv file is loaded.
Also if a fixup is needed it is logged at level info with the rest of
the database logging. Also success of the fixup is logged. Fixup
failure generates a propagated exception.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Mon, 07 Jun 2021 09:58:39 -0400 |
| parents | 198b6e810c67 |
| children |
| rev | line source |
|---|---|
|
5248
198b6e810c67
Use Python-3-compatible 'as' syntax for except statements
Eric S. Raymond <esr@thyrsus.com>
parents:
5037
diff
changeset
|
1 #-*- encoding: utf-8 -*- |
|
4816
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
2 |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
3 import unittest, os, pprint, difflib, textwrap |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
4 |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
5 from roundup.init import loadTemplateInfo |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
6 |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
7 |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
8 class TemplateInfoTestCase(unittest.TestCase): |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
9 def testLoadTemplateInfo(self): |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
10 path = os.path.join(os.path.dirname(__file__), |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
11 '../share/roundup/templates/classic') |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
12 self.maxDiff = None |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
13 self.assertEqual( |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
14 loadTemplateInfo(path), |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
15 { |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
16 'description': textwrap.dedent('''\ |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
17 This is a generic issue tracker that may be used to track bugs, |
|
4818
edb171528a7d
init.loadTemplateInfo: replace rfc822 with email.parser (Python 3 compatible)
anatoly techtonik <techtonik@gmail.com>
parents:
4816
diff
changeset
|
18 feature requests, project issues or any number of other types |
|
edb171528a7d
init.loadTemplateInfo: replace rfc822 with email.parser (Python 3 compatible)
anatoly techtonik <techtonik@gmail.com>
parents:
4816
diff
changeset
|
19 of issues. Most users of Roundup will find that this template |
|
edb171528a7d
init.loadTemplateInfo: replace rfc822 with email.parser (Python 3 compatible)
anatoly techtonik <techtonik@gmail.com>
parents:
4816
diff
changeset
|
20 suits them, with perhaps a few customisations.'''), |
|
4816
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
21 'intended-for': 'All first-time Roundup users', |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
22 'name': 'classic', |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
23 'path': path |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
24 } |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
25 ) |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
26 |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
27 # vim: set et sts=4 sw=4 : |
