Mercurial > p > roundup > code
annotate test/test_init.py @ 5222:9bf221cebef3
Make properties method return only properties the user can search.
See:
https://sourceforge.net/p/roundup/mailman/roundup-devel/thread/20170405002844.2004B80690%40vm71.cs.umb.edu/#msg35769250
[Roundup-devel] Bug in context/properties, lists properties user can't search.
The HTMLClass::properties() method returns a list of all
properties. This is used when creating sort on/group by filters on
index pages.
However somewhere in the code, a user needs search permission on the
property in order for it to be used for grouping or sorting.
This means the user can choose to sort/group an index page by a
property that they have no search permission for. As a result the
sort/group is ignored. This is confusing.
I have changed the properties method to only return properties the
user has View/Search permissions on. I also added a new cansearch
argument set by default to True. If set to False, all properties
regardless of Search permission are returned.
Doc updated to include the new default operation and mention the use
of cansearch argument.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Wed, 05 Apr 2017 21:38:32 -0400 |
| parents | 364c54991861 |
| children | 198b6e810c67 |
| rev | line source |
|---|---|
|
4816
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
1 #-*- encoding: utf8 -*- |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
2 |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
3 import unittest, os, pprint, difflib, textwrap |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
4 |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
5 from roundup.init import loadTemplateInfo |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
6 |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
7 |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
8 class TemplateInfoTestCase(unittest.TestCase): |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
9 def testLoadTemplateInfo(self): |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
10 path = os.path.join(os.path.dirname(__file__), |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
11 '../share/roundup/templates/classic') |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
12 self.maxDiff = None |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
13 self.assertEqual( |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
14 loadTemplateInfo(path), |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
15 { |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
16 'description': textwrap.dedent('''\ |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
17 This is a generic issue tracker that may be used to track bugs, |
|
4818
edb171528a7d
init.loadTemplateInfo: replace rfc822 with email.parser (Python 3 compatible)
anatoly techtonik <techtonik@gmail.com>
parents:
4816
diff
changeset
|
18 feature requests, project issues or any number of other types |
|
edb171528a7d
init.loadTemplateInfo: replace rfc822 with email.parser (Python 3 compatible)
anatoly techtonik <techtonik@gmail.com>
parents:
4816
diff
changeset
|
19 of issues. Most users of Roundup will find that this template |
|
edb171528a7d
init.loadTemplateInfo: replace rfc822 with email.parser (Python 3 compatible)
anatoly techtonik <techtonik@gmail.com>
parents:
4816
diff
changeset
|
20 suits them, with perhaps a few customisations.'''), |
|
4816
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
21 'intended-for': 'All first-time Roundup users', |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
22 'name': 'classic', |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
23 'path': path |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
24 } |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
25 ) |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
26 |
|
9b3e09a50d85
init.loadTemplateInfo: Add test
anatoly techtonik <techtonik@gmail.com>
parents:
diff
changeset
|
27 # vim: set et sts=4 sw=4 : |
