Mercurial > p > roundup > code
annotate roundup/dist/command/build.py @ 5222:9bf221cebef3
Make properties method return only properties the user can search.
See:
https://sourceforge.net/p/roundup/mailman/roundup-devel/thread/20170405002844.2004B80690%40vm71.cs.umb.edu/#msg35769250
[Roundup-devel] Bug in context/properties, lists properties user can't search.
The HTMLClass::properties() method returns a list of all
properties. This is used when creating sort on/group by filters on
index pages.
However somewhere in the code, a user needs search permission on the
property in order for it to be used for grouping or sorting.
This means the user can choose to sort/group an index page by a
property that they have no search permission for. As a result the
sort/group is ignored. This is confusing.
I have changed the properties method to only return properties the
user has View/Search permissions on. I also added a new cansearch
argument set by default to True. If set to False, all properties
regardless of Search permission are returned.
Doc updated to include the new default operation and mention the use
of cansearch argument.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Wed, 05 Apr 2017 21:38:32 -0400 |
| parents | 85dfe17c182e |
| children | 64b05e24dbd8 |
| rev | line source |
|---|---|
| 4068 | 1 # |
| 2 # Copyright (C) 2009 Stefan Seefeld | |
| 3 # All rights reserved. | |
| 4 # For license terms see the file COPYING.txt. | |
| 5 # | |
| 6 from roundup import msgfmt | |
| 7 from distutils.command.build import build as base | |
| 8 import os | |
| 9 from glob import glob | |
| 10 | |
| 11 def list_message_files(suffix=".po"): | |
| 12 """Return list of all found message files and their intallation paths""" | |
| 13 _files = glob("locale/*" + suffix) | |
| 14 _list = [] | |
| 15 for _file in _files: | |
| 16 # basename (without extension) is a locale name | |
| 17 _locale = os.path.splitext(os.path.basename(_file))[0] | |
| 18 _list.append((_file, os.path.join( | |
| 19 "share", "locale", _locale, "LC_MESSAGES", "roundup.mo"))) | |
| 20 return _list | |
| 21 | |
| 22 def check_manifest(): | |
| 23 """Check that the files listed in the MANIFEST are present when the | |
| 24 source is unpacked. | |
| 25 """ | |
| 26 try: | |
| 27 f = open('MANIFEST') | |
| 28 except: | |
| 29 print '\n*** SOURCE WARNING: The MANIFEST file is missing!' | |
| 30 return | |
| 31 try: | |
| 32 manifest = [l.strip() for l in f.readlines()] | |
| 33 finally: | |
| 34 f.close() | |
|
4394
d4cd0a264098
fixed reporting of source missing warnings
Richard Jones <richard@users.sourceforge.net>
parents:
4068
diff
changeset
|
35 err = set([line for line in manifest if not os.path.exists(line)]) |
| 4068 | 36 # ignore auto-generated files |
|
4394
d4cd0a264098
fixed reporting of source missing warnings
Richard Jones <richard@users.sourceforge.net>
parents:
4068
diff
changeset
|
37 err = err - set(['roundup-admin', 'roundup-demo', 'roundup-gettext', |
|
d4cd0a264098
fixed reporting of source missing warnings
Richard Jones <richard@users.sourceforge.net>
parents:
4068
diff
changeset
|
38 'roundup-mailgw', 'roundup-server', 'roundup-xmlrpc-server']) |
| 4068 | 39 if err: |
| 40 n = len(manifest) | |
| 41 print '\n*** SOURCE WARNING: There are files missing (%d/%d found)!'%( | |
| 42 n-len(err), n) | |
| 43 print 'Missing:', '\nMissing: '.join(err) | |
| 44 | |
|
4516
85dfe17c182e
Installation:
Bernhard Reiter <Bernhard.Reiter@intevation.de>
parents:
4394
diff
changeset
|
45 def build_message_files(command): |
|
85dfe17c182e
Installation:
Bernhard Reiter <Bernhard.Reiter@intevation.de>
parents:
4394
diff
changeset
|
46 """For each locale/*.po, build .mo file in target locale directory""" |
|
85dfe17c182e
Installation:
Bernhard Reiter <Bernhard.Reiter@intevation.de>
parents:
4394
diff
changeset
|
47 for (_src, _dst) in list_message_files(): |
|
85dfe17c182e
Installation:
Bernhard Reiter <Bernhard.Reiter@intevation.de>
parents:
4394
diff
changeset
|
48 _build_dst = os.path.join("build", _dst) |
|
85dfe17c182e
Installation:
Bernhard Reiter <Bernhard.Reiter@intevation.de>
parents:
4394
diff
changeset
|
49 command.mkpath(os.path.dirname(_build_dst)) |
|
85dfe17c182e
Installation:
Bernhard Reiter <Bernhard.Reiter@intevation.de>
parents:
4394
diff
changeset
|
50 command.announce("Compiling %s -> %s" % (_src, _build_dst)) |
|
85dfe17c182e
Installation:
Bernhard Reiter <Bernhard.Reiter@intevation.de>
parents:
4394
diff
changeset
|
51 msgfmt.make(_src, _build_dst) |
|
85dfe17c182e
Installation:
Bernhard Reiter <Bernhard.Reiter@intevation.de>
parents:
4394
diff
changeset
|
52 |
| 4068 | 53 |
| 54 class build(base): | |
| 55 | |
| 56 def run(self): | |
| 57 check_manifest() | |
|
4516
85dfe17c182e
Installation:
Bernhard Reiter <Bernhard.Reiter@intevation.de>
parents:
4394
diff
changeset
|
58 build_message_files(self) |
| 4068 | 59 base.run(self) |
| 60 |
