annotate roundup/anypy/html.py @ 7155:89a59e46b3af

improve REST interface security When using REST, we reflect the client's origin. If the wildcard '*' is used in allowed_api_origins all origins are allowed. When this is done, it also added an 'Access-Control-Allow-Credentials: true' header. This Credentials header should not be added if the site is matched only by '*'. This header should be provided only for explicit origins (e.g. https://example.org) not for the wildcard. This is now fixed for CORS preflight OPTIONS request as well as normal GET, PUT, DELETE, POST, PATCH and OPTIONS requests. A missing Access-Control-Allow-Credentials will prevent the tracker from being accessed using credentials. This prevents an unauthorized third party web site from using a user's credentials to access information in the tracker that is not publicly available. Added test for this specific case. In addition, allowed_api_origins can include explicit origins in addition to '*'. '*' must be first in the list. Also adapted numerous tests to work with these changes. Doc updates.
author John Rouillard <rouilj@ieee.org>
date Thu, 23 Feb 2023 12:01:33 -0500
parents ff57db595a58
children 7f888f046857
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
5837
883c9e90b403 Fix problem with cgi.escape being depricated a different way. This way
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
1 try:
6027
ff57db595a58 flake8 cleanups whitespace formatting only.
John Rouillard <rouilj@ieee.org>
parents: 5837
diff changeset
2 from html import escape as html_escape_ # python 3
ff57db595a58 flake8 cleanups whitespace formatting only.
John Rouillard <rouilj@ieee.org>
parents: 5837
diff changeset
3
5837
883c9e90b403 Fix problem with cgi.escape being depricated a different way. This way
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
4 def html_escape(str, quote=False):
883c9e90b403 Fix problem with cgi.escape being depricated a different way. This way
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
5 # html_escape under python 3 sets quote to true by default
883c9e90b403 Fix problem with cgi.escape being depricated a different way. This way
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
6 # make it python 2 compatible
883c9e90b403 Fix problem with cgi.escape being depricated a different way. This way
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
7 return html_escape_(str, quote=quote)
883c9e90b403 Fix problem with cgi.escape being depricated a different way. This way
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
8 except ImportError:
6027
ff57db595a58 flake8 cleanups whitespace formatting only.
John Rouillard <rouilj@ieee.org>
parents: 5837
diff changeset
9 # python 2 fallback
ff57db595a58 flake8 cleanups whitespace formatting only.
John Rouillard <rouilj@ieee.org>
parents: 5837
diff changeset
10 from cgi import escape as html_escape # noqa: F401

Roundup Issue Tracker: http://roundup-tracker.org/