Mercurial > p > roundup > code
annotate scripts/weekly-report @ 5414:3fa026621f69
Python 3 preparation: comparisons.
Python 3 no longer has the cmp function, or cmp= arguments to sorting
functions / methods (key= must be used instead), and requires rich
comparison methods such as __lt__ to be defined instead of using
__cmp__. All of the comparison mechanisms supported in Python 3 are
also supported in Python 2.
This patch makes the corresponding changes in Roundup to use key
functions and rich comparison methods. In the case of the
JournalPassword and Permission classes, only __eq__ and __ne__ are
defined as I don't see ordered comparisons as useful there (and for
Permission, the old __cmp__ function didn't try to provide a valid
ordering). In the case of the Date class, I kept the __cmp__ method
and implemented the others in terms of it, to avoid excess
repetitiveness in duplicating implementation code for all six rich
comparison methods.
In roundup/admin.py, help_commands_html used operator.attrgetter to
produce the second argument of sorted() - which would be reasonable
for a key function, but the second argument is the cmp function in
Python 2, not a key function (and the key function must be a named
argument not a positional argument in Python 3). That function
appears to be completely unused, so I expect that code never worked.
This patch adds the missing key= to that sorted() call, but it would
also be reasonable to remove the unused function completely instead.
| author | Joseph Myers <jsm@polyomino.org.uk> |
|---|---|
| date | Wed, 25 Jul 2018 00:39:37 +0000 |
| parents | c75defc1c2f0 |
| children | 20ab9a4b76e9 |
| rev | line source |
|---|---|
| 4041 | 1 #! /usr/bin/env python |
| 3764 | 2 |
| 3 # This script generates a simple report outlining the activity in one | |
| 4 # tracker for the most recent week. | |
| 5 | |
| 6 # This script is free software, you may redistribute it | |
| 7 # and/or modify under the same terms as Python. | |
| 8 | |
|
5412
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4041
diff
changeset
|
9 from __future__ import print_function |
| 3764 | 10 import sys, math |
| 11 from roundup import instance, date | |
| 12 | |
| 13 # open the instance | |
| 14 if len(sys.argv) != 2: | |
|
5412
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4041
diff
changeset
|
15 print('You need to specify an instance home dir') |
| 3764 | 16 instance_home = sys.argv[1] |
| 17 instance = instance.open(instance_home) | |
| 18 db = instance.open('admin') | |
| 19 | |
| 20 old = date.Date('-1w') | |
| 21 | |
| 22 created = [] | |
| 23 summary = {} | |
| 24 messages = [] | |
| 25 | |
| 26 # loop through all the recently-active issues | |
| 27 for issue_id in db.issue.filter(None, {'activity': '-1w;'}): | |
| 28 num = 0 | |
| 29 for x,ts,userid,action,data in db.issue.history(issue_id): | |
| 30 if ts < old: continue | |
| 31 if action == 'create': | |
| 32 created.append(issue_id) | |
|
5412
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4041
diff
changeset
|
33 elif action == 'set' and 'messages' in data: |
| 3764 | 34 num += 1 |
| 35 summary.setdefault(db.issue.get(issue_id, 'status'), []).append(issue_id) | |
| 36 messages.append((num, issue_id)) | |
| 37 | |
| 38 #print 'STATUS SUMMARY:' | |
| 39 #for k,v in summary.items(): | |
| 40 # print k, len(v) | |
| 41 | |
|
5412
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4041
diff
changeset
|
42 print('\nCREATED:') |
|
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4041
diff
changeset
|
43 print('\n'.join(['%s: %s'%(id, db.issue.get(id, 'title')) |
|
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4041
diff
changeset
|
44 for id in created])) |
| 3764 | 45 |
|
5412
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4041
diff
changeset
|
46 print('\nRESOLVED:') |
| 3764 | 47 resolved_id = db.status.lookup('resolved') |
|
5412
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4041
diff
changeset
|
48 print('\n'.join(['%s: %s'%(id, db.issue.get(id, 'title')) |
|
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4041
diff
changeset
|
49 for id in summary.get(resolved_id, [])])) |
| 3764 | 50 |
|
5412
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4041
diff
changeset
|
51 print('\nTOP TEN MOST DISCUSSED:') |
| 3764 | 52 messages.sort() |
| 53 messages.reverse() | |
| 54 nmax = messages[0][0] | |
| 55 fmt = '%%%dd - %%s: %%s'%(int(math.log(nmax, 10)) + 1) | |
|
5412
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4041
diff
changeset
|
56 print('\n'.join([fmt%(num, id, db.issue.get(id, 'title')) |
|
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4041
diff
changeset
|
57 for num, id in messages[:10]])) |
| 3764 | 58 |
| 59 # vim: set filetype=python ts=4 sw=4 et si |
