Mercurial > p > roundup > code
annotate scripts/add-issue @ 5414:3fa026621f69
Python 3 preparation: comparisons.
Python 3 no longer has the cmp function, or cmp= arguments to sorting
functions / methods (key= must be used instead), and requires rich
comparison methods such as __lt__ to be defined instead of using
__cmp__. All of the comparison mechanisms supported in Python 3 are
also supported in Python 2.
This patch makes the corresponding changes in Roundup to use key
functions and rich comparison methods. In the case of the
JournalPassword and Permission classes, only __eq__ and __ne__ are
defined as I don't see ordered comparisons as useful there (and for
Permission, the old __cmp__ function didn't try to provide a valid
ordering). In the case of the Date class, I kept the __cmp__ method
and implemented the others in terms of it, to avoid excess
repetitiveness in duplicating implementation code for all six rich
comparison methods.
In roundup/admin.py, help_commands_html used operator.attrgetter to
produce the second argument of sorted() - which would be reasonable
for a key function, but the second argument is the cmp function in
Python 2, not a key function (and the key function must be a named
argument not a positional argument in Python 3). That function
appears to be completely unused, so I expect that code never worked.
This patch adds the missing key= to that sorted() call, but it would
also be reasonable to remove the unused function completely instead.
| author | Joseph Myers <jsm@polyomino.org.uk> |
|---|---|
| date | Wed, 25 Jul 2018 00:39:37 +0000 |
| parents | c75defc1c2f0 |
| children | 9c3ec0a5c7fc |
| rev | line source |
|---|---|
|
1626
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
1 #! /usr/bin/env python |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
2 ''' |
|
1627
e029d625c8f1
minor usage doc tweak
Richard Jones <richard@users.sourceforge.net>
parents:
1626
diff
changeset
|
3 Usage: %s <tracker home> <priority> <issue title> |
|
1626
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
4 |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
5 Create a new issue in the given tracker. Input is taken from STDIN to |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
6 create the initial issue message (which may be empty). Issues will be |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
7 created as the current user (%s) if they exist as a Roundup |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
8 user, or "admin" otherwise. |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
9 ''' |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
10 |
|
5412
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4781
diff
changeset
|
11 from __future__ import print_function |
|
1626
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
12 import sys, os, pwd |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
13 |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
14 from roundup import instance, mailgw, date |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
15 |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
16 # open the instance |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
17 username = pwd.getpwuid(os.getuid())[0] |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
18 if len(sys.argv) < 3: |
|
5412
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4781
diff
changeset
|
19 print("Error: Not enough arguments") |
|
c75defc1c2f0
Python 3 preparation: miscellaneous Python scripts not named *.py.
Joseph Myers <jsm@polyomino.org.uk>
parents:
4781
diff
changeset
|
20 print(__doc__.strip()%(sys.argv[0], username)) |
|
1626
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
21 sys.exit(1) |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
22 tracker_home = sys.argv[1] |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
23 issue_priority = sys.argv[2] |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
24 issue_title = ' '.join(sys.argv[3:]) |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
25 |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
26 # get the message, if any |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
27 message_text = sys.stdin.read().strip() |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
28 |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
29 # open the tracker |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
30 tracker = instance.open(tracker_home) |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
31 db = tracker.open('admin') |
| 4781 | 32 db.tx_Source = "cli" |
|
1626
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
33 uid = db.user.lookup('admin') |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
34 try: |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
35 # try to open the tracker as the current user |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
36 uid = db.user.lookup(username) |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
37 db.close() |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
38 db = tracker.open(username) |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
39 except KeyError: |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
40 pass |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
41 |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
42 try: |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
43 |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
44 # handle the message |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
45 messages = [] |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
46 if message_text: |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
47 summary, x = mailgw.parseContent(message_text, 0, 0) |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
48 msg = db.msg.create(content=message_text, summary=summary, author=uid, |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
49 date=date.Date()) |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
50 messages = [msg] |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
51 |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
52 # now create the issue |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
53 db.issue.create(title=issue_title, priority=issue_priority, |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
54 messages=messages) |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
55 |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
56 db.commit() |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
57 finally: |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
58 db.close() |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
59 |
|
581aa1853a2f
adding a simple add-issue script
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
60 # vim: set filetype=python ts=4 sw=4 et si |
