Mercurial > p > roundup > code
annotate test/test_mailer.py @ 8265:35beff316883
fix(api): issue2551384. Verify REST authorization earlier
To reduce the ability of bad actors to spam (DOS) the REST endpoint
with bad data and generate logs meant for debugging, modify the flow
in client.py's REST handler to verify authorization earlier.
If the anonymous user is allowed to use REST, this won't make a
difference for a DOS attempt. The templates don't enable REST for the
anonymous user by default. Most admins don't change this.
The validation order for REST requests has been changed.
CORS identfied an handled
User authorization to use REST (return 403 on failure)
REST request validated (Origin header valid etc.) (return 400 for
bad request)
Incorrectly formatted CORS preflight requests (e.g. missing Origin
header) that are not recogized as a CORS request can now return HTTP
status 403 as well as status 400 (when anonymous is allowed
access). Note all CORS preflights are sent without authentication so
appear as anonymous requests.
The tests were updated to compensate, but it is not obvious to me from
specs what the proper evaulation order/return codes should be for this
case. Both 403/400 are failures and cause CORS to fail so there should
be no difference but...
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Thu, 09 Jan 2025 09:30:08 -0500 |
| parents | 95a366d46065 |
| children |
| rev | line source |
|---|---|
|
5248
198b6e810c67
Use Python-3-compatible 'as' syntax for except statements
Eric S. Raymond <esr@thyrsus.com>
parents:
5037
diff
changeset
|
1 #-*- encoding: utf-8 -*- |
|
4338
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
2 import unittest |
|
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
3 |
|
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
4 from roundup import mailer |
|
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
5 |
|
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
6 class EncodingTestCase(unittest.TestCase): |
|
4520
182d8c41a3aa
Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents:
4338
diff
changeset
|
7 def testEncoding(self): |
|
5794
95a366d46065
Replace deprecated assertEquals with assertEqual and failUnlessRaises
John Rouillard <rouilj@ieee.org>
parents:
5458
diff
changeset
|
8 a = lambda n, a, c, o: self.assertEqual(mailer.nice_sender_header(n, |
|
4338
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
9 a, c), o) |
|
4520
182d8c41a3aa
Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents:
4338
diff
changeset
|
10 a('ascii', 'ascii@test.com', 'iso8859-1', 'ascii <ascii@test.com>') |
|
182d8c41a3aa
Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents:
4338
diff
changeset
|
11 a(u'café', 'ascii@test.com', 'iso8859-1', |
|
182d8c41a3aa
Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents:
4338
diff
changeset
|
12 '=?iso8859-1?q?caf=E9?= <ascii@test.com>') |
|
5458
bc2e682e0305
fixed encoding issues in mailer
Christof Meerwald <cmeerw@cmeerw.org>
parents:
5248
diff
changeset
|
13 a(u'café', 'ascii@test.com', 'utf-8', |
|
bc2e682e0305
fixed encoding issues in mailer
Christof Meerwald <cmeerw@cmeerw.org>
parents:
5248
diff
changeset
|
14 '=?utf-8?b?Y2Fmw6k=?= <ascii@test.com>') |
|
4520
182d8c41a3aa
Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents:
4338
diff
changeset
|
15 a('as"ii', 'ascii@test.com', 'iso8859-1', '"as\\"ii" <ascii@test.com>') |
|
4338
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
16 |
|
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
17 # vim: set et sts=4 sw=4 : |
