annotate test/conftest.py @ 8265:35beff316883

fix(api): issue2551384. Verify REST authorization earlier To reduce the ability of bad actors to spam (DOS) the REST endpoint with bad data and generate logs meant for debugging, modify the flow in client.py's REST handler to verify authorization earlier. If the anonymous user is allowed to use REST, this won't make a difference for a DOS attempt. The templates don't enable REST for the anonymous user by default. Most admins don't change this. The validation order for REST requests has been changed. CORS identfied an handled User authorization to use REST (return 403 on failure) REST request validated (Origin header valid etc.) (return 400 for bad request) Incorrectly formatted CORS preflight requests (e.g. missing Origin header) that are not recogized as a CORS request can now return HTTP status 403 as well as status 400 (when anonymous is allowed access). Note all CORS preflights are sent without authentication so appear as anonymous requests. The tests were updated to compensate, but it is not obvious to me from specs what the proper evaulation order/return codes should be for this case. Both 403/400 are failures and cause CORS to fail so there should be no difference but...
author John Rouillard <rouilj@ieee.org>
date Thu, 09 Jan 2025 09:30:08 -0500
parents 619b723dd2bb
children 43dc610bbd24
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
7719
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
1 # simple way to see if there are order dependencies in tests
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
2 # can use if pytest-random-order --random-order mode isn't
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
3 # usable (e.g. python2).
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
4
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
5 #def pytest_collection_modifyitems(items):
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
6 # items.reverse()
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
7
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
8 # Add a marker for pg_schema tests.
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
9 # They duplicate the postgresql tests exactly but uses a named
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
10 # schema rather than the default 'public' schema.
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
11 def pytest_configure(config):
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
12 config.addinivalue_line(
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
13 "markers", "pg_schema: tests using schema for postgres"
3071db43bfb6 feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff changeset
14 )
8251
619b723dd2bb test: try to handle loss of testmon data when cancelling test.
John Rouillard <rouilj@ieee.org>
parents: 7719
diff changeset
15
619b723dd2bb test: try to handle loss of testmon data when cancelling test.
John Rouillard <rouilj@ieee.org>
parents: 7719
diff changeset
16 # try to work around loss of testmon data when ^Cing out of tests.
619b723dd2bb test: try to handle loss of testmon data when cancelling test.
John Rouillard <rouilj@ieee.org>
parents: 7719
diff changeset
17 def pytest_unconfigure(config):
619b723dd2bb test: try to handle loss of testmon data when cancelling test.
John Rouillard <rouilj@ieee.org>
parents: 7719
diff changeset
18 if hasattr(config, "testmon_data"):
619b723dd2bb test: try to handle loss of testmon data when cancelling test.
John Rouillard <rouilj@ieee.org>
parents: 7719
diff changeset
19 config.testmon_data.db.con.close()
619b723dd2bb test: try to handle loss of testmon data when cancelling test.
John Rouillard <rouilj@ieee.org>
parents: 7719
diff changeset
20

Roundup Issue Tracker: http://roundup-tracker.org/