Mercurial > p > roundup > code
annotate test/test_mailer.py @ 8177:2967f37e73e4
refactor: issue2551289. invalid REST Accept header stops request
Sending a POST, PUT (maybe PATCH) with an accept header that is not
application/json or xml (if enabled) used to complete the request
before throwing a 406 error. This was wrong.
Now it reports an error without dispatching/processing the requested
transaction. This is the first of a series of refactors of the
dispatch method to make it faster and more readable by using return
early pattern and extracting methods from the code.
changes:
The following now return 406 errors not 400 errors
invalid version specified with @apiver in URL.
invalid version specified with @apiver in payload body
invalid version specified in accept headers as
application/vnd.roundup.test-vz+json or version property
Parsing the accept header returns a 400 when presented with a
parameter without an = sign or other parse error. They used to
return a 406 which is wrong since the header is malformed rather
than having a value I can't respond to.
Some error messages were made clearer.
Results in the case of an error are proper json error object rather
than text/plain strings.
New test added for testdetermine_output_formatBadAccept that test the
new method using the same test cases as for
testDispatchBadAccept. I intend to extend the test coverage for
determine_output_format to cover more cases. This should be a faster
unit test than for dispatch.
Removed .lower() calls for accept_mime_type as the input values are
taken from the values in the __accepted_content_type dict which
only has lower case values.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sun, 08 Dec 2024 01:09:34 -0500 |
| parents | 95a366d46065 |
| children |
| rev | line source |
|---|---|
|
5248
198b6e810c67
Use Python-3-compatible 'as' syntax for except statements
Eric S. Raymond <esr@thyrsus.com>
parents:
5037
diff
changeset
|
1 #-*- encoding: utf-8 -*- |
|
4338
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
2 import unittest |
|
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
3 |
|
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
4 from roundup import mailer |
|
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
5 |
|
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
6 class EncodingTestCase(unittest.TestCase): |
|
4520
182d8c41a3aa
Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents:
4338
diff
changeset
|
7 def testEncoding(self): |
|
5794
95a366d46065
Replace deprecated assertEquals with assertEqual and failUnlessRaises
John Rouillard <rouilj@ieee.org>
parents:
5458
diff
changeset
|
8 a = lambda n, a, c, o: self.assertEqual(mailer.nice_sender_header(n, |
|
4338
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
9 a, c), o) |
|
4520
182d8c41a3aa
Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents:
4338
diff
changeset
|
10 a('ascii', 'ascii@test.com', 'iso8859-1', 'ascii <ascii@test.com>') |
|
182d8c41a3aa
Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents:
4338
diff
changeset
|
11 a(u'café', 'ascii@test.com', 'iso8859-1', |
|
182d8c41a3aa
Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents:
4338
diff
changeset
|
12 '=?iso8859-1?q?caf=E9?= <ascii@test.com>') |
|
5458
bc2e682e0305
fixed encoding issues in mailer
Christof Meerwald <cmeerw@cmeerw.org>
parents:
5248
diff
changeset
|
13 a(u'café', 'ascii@test.com', 'utf-8', |
|
bc2e682e0305
fixed encoding issues in mailer
Christof Meerwald <cmeerw@cmeerw.org>
parents:
5248
diff
changeset
|
14 '=?utf-8?b?Y2Fmw6k=?= <ascii@test.com>') |
|
4520
182d8c41a3aa
Fix mailer encoding test:
Ralf Schlatterbeck <schlatterbeck@users.sourceforge.net>
parents:
4338
diff
changeset
|
15 a('as"ii', 'ascii@test.com', 'iso8859-1', '"as\\"ii" <ascii@test.com>') |
|
4338
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
16 |
|
94ee533613ac
Attempt to generate more human-readable addresses in email
Richard Jones <richard@users.sourceforge.net>
parents:
diff
changeset
|
17 # vim: set et sts=4 sw=4 : |
