Mercurial > p > roundup > code
annotate test/conftest.py @ 8472:224ccb8b49ca
refactor: change some classes to use __slots__
Speed up access to and reduce size of some low level classes. A few
classes in security.py, rest.py are heavily used. But for all, it
prevents adding random properties to lower level classes that people
shouldn't be mucking with. While doing this I found some test cases
accessing an invalid property name and this change caused the cases to
crash.
admin.py:
Use new method Role.props_dict() and Permission.props_dict() where
original code just referenced __dict__ when printing Role/Permission.
mlink_expr.py:
Add slots to multiple classes.
Classes Binary and Unary set real properties/attributes. Classes that
inherit from them (Equals, Empty, Not, Or, And) define empty slots
tuple to eliminate need for __dict__.
Class Expression also gets a slot.
rate_limit.py:
RateLimit and Gcra classes get slots.
A couple of pep8 fixes: sort imports, remove trailing spaces on a
line, remove unused noqa comment.
rest.py:
Add slots to class SimulateFieldStorageFromJson and FsValue
classes. The memory savings from this could be useful as well as
speedier access to the attributes.
security.py:
Add slots to Permission class. To prevent conflict between slot
limit_perm_to_props_only and the class variable of the same name,
rename the class variable to limit_perm_to_props_only_default.
Also define method props_dict() to allow other code to get a dict to
iterate over when checking permissions.
Add slots to class Role along with props_dict() method.
Add slots to class Security. Also have to add explicit __dict__ slot
to support test override of the hasPermission() method. Add
props_dict() method, currently unused, but added for symmetry.
support.py:
TruthDict and PrioList gets slots.
test/test_cgi.py:
Fix incorrect setting of permission property. Was setting
permissions. So testing may not have been doing what we thought it
was. Multiple places found with this typo.
Remove setting of permissions in some places where it should
have no effect on the test and looks like it was just copypasta.
test/test_xmlrpc.py
Remove setting of permissions in some places where it should
have no effect on the test and looks like it was just copypasta.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Mon, 03 Nov 2025 00:13:04 -0500 |
| parents | 43dc610bbd24 |
| children |
| rev | line source |
|---|---|
|
7719
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
1 # simple way to see if there are order dependencies in tests |
|
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
2 # can use if pytest-random-order --random-order mode isn't |
|
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
3 # usable (e.g. python2). |
|
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
4 |
|
8266
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
5 |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
6 # known issues: |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
7 # python3 -m pytest -k Whoosh test/test_indexer.py fails starting with |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
8 # first reversed (so last) test in module |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
9 # |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
10 # python3 -m pytest test/test_cgi.py |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
11 # fails: FormTestCase::testCreatePermission |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
12 # FormTestCase::testClassPermission |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
13 # FormTestCase::testCheckAndPropertyPermission |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
14 # |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
15 # this failure results in a failure in test_action again with |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
16 # bad permission application. Something run prior to these |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
17 # tests is breaking the permission checks. |
|
43dc610bbd24
doc: known issues with possible dependent tests
John Rouillard <rouilj@ieee.org>
parents:
8251
diff
changeset
|
18 |
|
7719
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
19 #def pytest_collection_modifyitems(items): |
|
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
20 # items.reverse() |
|
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
21 |
|
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
22 # Add a marker for pg_schema tests. |
|
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
23 # They duplicate the postgresql tests exactly but uses a named |
|
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
24 # schema rather than the default 'public' schema. |
|
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
25 def pytest_configure(config): |
|
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
26 config.addinivalue_line( |
|
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
27 "markers", "pg_schema: tests using schema for postgres" |
|
3071db43bfb6
feat: issue2550852 - support using a specified PostgreSQL db schema
John Rouillard <rouilj@ieee.org>
parents:
diff
changeset
|
28 ) |
|
8251
619b723dd2bb
test: try to handle loss of testmon data when cancelling test.
John Rouillard <rouilj@ieee.org>
parents:
7719
diff
changeset
|
29 |
|
619b723dd2bb
test: try to handle loss of testmon data when cancelling test.
John Rouillard <rouilj@ieee.org>
parents:
7719
diff
changeset
|
30 # try to work around loss of testmon data when ^Cing out of tests. |
|
619b723dd2bb
test: try to handle loss of testmon data when cancelling test.
John Rouillard <rouilj@ieee.org>
parents:
7719
diff
changeset
|
31 def pytest_unconfigure(config): |
|
619b723dd2bb
test: try to handle loss of testmon data when cancelling test.
John Rouillard <rouilj@ieee.org>
parents:
7719
diff
changeset
|
32 if hasattr(config, "testmon_data"): |
|
619b723dd2bb
test: try to handle loss of testmon data when cancelling test.
John Rouillard <rouilj@ieee.org>
parents:
7719
diff
changeset
|
33 config.testmon_data.db.con.close() |
|
619b723dd2bb
test: try to handle loss of testmon data when cancelling test.
John Rouillard <rouilj@ieee.org>
parents:
7719
diff
changeset
|
34 |
